From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8452 invoked by alias); 31 Oct 2002 19:26:46 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 8444 invoked from network); 31 Oct 2002 19:26:45 -0000 Received: from unknown (HELO localhost.redhat.com) (216.138.202.10) by sources.redhat.com with SMTP; 31 Oct 2002 19:26:45 -0000 Received: from redhat.com (localhost [127.0.0.1]) by localhost.redhat.com (Postfix) with ESMTP id 084253C9D; Thu, 31 Oct 2002 14:26:43 -0500 (EST) Message-ID: <3DC183F2.5080304@redhat.com> Date: Thu, 31 Oct 2002 11:26:00 -0000 From: Andrew Cagney User-Agent: Mozilla/5.0 (X11; U; NetBSD macppc; en-US; rv:1.0.0) Gecko/20020824 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Joel Brobecker Cc: gdb-patches@sources.redhat.com Subject: Re: [RFA/5.3] Fix a compilation warning in hppa-tdep.c References: <20021030232154.GP903@gnat.com> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2002-10/txt/msg00604.txt.bz2 > I am not sure we want to pull this change in the 5.3 branch, as it does > not fix any regression. It's the change I checked in the trunk to fix a > compilation warning - the same warning appears in the 5.3 branch, so I > though I'd suggest it there too. > > 2002-10-30 Joel Brobecker > > * hppa-tdep.c (low_text_segment_addres): Fix a compilation warning. > > Should I apply it? I say `Yes', and the same for any other HP changes you feel should be pulled in from the mainline. Just keep an eye out for my long over due e-mail indicating `stop, no more 5.3 changes' :-/ > Index: hppa-tdep.c > =================================================================== > RCS file: /cvs/src/src/gdb/hppa-tdep.c,v > retrieving revision 1.27 > diff -c -3 -p -r1.27 hppa-tdep.c > *** hppa-tdep.c 5 May 2002 01:15:13 -0000 1.27 > --- hppa-tdep.c 30 Oct 2002 23:10:55 -0000 > *************** static CORE_ADDR low_text_segment_addres > *** 300,306 **** > static void > record_text_segment_lowaddr (bfd *abfd, asection *section, void *ignored) > { > ! if ((section->flags & (SEC_ALLOC | SEC_LOAD | SEC_READONLY) > == (SEC_ALLOC | SEC_LOAD | SEC_READONLY)) > && section->vma < low_text_segment_address) > low_text_segment_address = section->vma; > --- 300,306 ---- > static void > record_text_segment_lowaddr (bfd *abfd, asection *section, void *ignored) > { > ! if (((section->flags & (SEC_ALLOC | SEC_LOAD | SEC_READONLY)) > == (SEC_ALLOC | SEC_LOAD | SEC_READONLY)) > && section->vma < low_text_segment_address) > low_text_segment_address = section->vma;