Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Andrew Cagney <ac131313@redhat.com>
To: Joel Brobecker <brobecker@gnat.com>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [RFA/5.3] Fix a compilation warning in hppa-tdep.c
Date: Thu, 31 Oct 2002 11:26:00 -0000	[thread overview]
Message-ID: <3DC183F2.5080304@redhat.com> (raw)
In-Reply-To: <20021030232154.GP903@gnat.com>

> I am not sure we want to pull this change in the 5.3 branch, as it does
> not fix any regression. It's the change I checked in the trunk to fix a
> compilation warning - the same warning appears in the 5.3 branch, so I
> though I'd suggest it there too.
> 
> 2002-10-30  Joel Brobecker  <brobecker@gnat.com>
> 
>         * hppa-tdep.c (low_text_segment_addres): Fix a compilation warning.
> 
> Should I apply it?

I say `Yes', and the same for any other HP changes you feel should be 
pulled in from the mainline.

Just keep an eye out for my long over due e-mail indicating `stop, no 
more 5.3 changes' :-/

> Index: hppa-tdep.c
> ===================================================================
> RCS file: /cvs/src/src/gdb/hppa-tdep.c,v
> retrieving revision 1.27
> diff -c -3 -p -r1.27 hppa-tdep.c
> *** hppa-tdep.c	5 May 2002 01:15:13 -0000	1.27
> --- hppa-tdep.c	30 Oct 2002 23:10:55 -0000
> *************** static CORE_ADDR low_text_segment_addres
> *** 300,306 ****
>   static void
>   record_text_segment_lowaddr (bfd *abfd, asection *section, void *ignored)
>   {
> !   if ((section->flags & (SEC_ALLOC | SEC_LOAD | SEC_READONLY)
>          == (SEC_ALLOC | SEC_LOAD | SEC_READONLY))
>         && section->vma < low_text_segment_address)
>       low_text_segment_address = section->vma;
> --- 300,306 ----
>   static void
>   record_text_segment_lowaddr (bfd *abfd, asection *section, void *ignored)
>   {
> !   if (((section->flags & (SEC_ALLOC | SEC_LOAD | SEC_READONLY))
>          == (SEC_ALLOC | SEC_LOAD | SEC_READONLY))
>         && section->vma < low_text_segment_address)
>       low_text_segment_address = section->vma;



  reply	other threads:[~2002-10-31 19:26 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-10-30 15:20 Joel Brobecker
2002-10-31 11:26 ` Andrew Cagney [this message]
2002-10-31 15:39   ` Joel Brobecker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3DC183F2.5080304@redhat.com \
    --to=ac131313@redhat.com \
    --cc=brobecker@gnat.com \
    --cc=gdb-patches@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox