[patch] change knr function definitions in ada-lang.c, ada-typeprint.c, ada-valprint.c

[patch] change knr function definitions in ada-lang.c, ada-typeprint.c, ada-valprint.c

[Aidan Skinner]

[-- Attachment #1.1: Type: text/plain, Size: 772 bytes --]

This slightly large patch (14k bzipped, sorry), changes the function
definitions in ada-lang.c, ada-typeprint.c and ada-valprint.c to use
ISO C prototypes.

Changelog:

2002-07-24  Aidan Skinner <aidan@velvet.net>

	* ada-lang.c: Change k&r style function definitions to prototyped
	form.
	* ada-typeprint.c: Change k&r style function definitions to prototyped
	form.
	* ada-valprint.c: Change k&r style function definitions to prototyped
	form.

Patch is attached. Committed as obvious.

- Aidan
-- 
aidan@velvet.net  http://www.velvet.net/~aidan/  aim:aidans42
finger for pgp key fingerprint |- - - - - - - - - - - - - - -
01AA 1594 2DB0 09E3 B850       | World Domination, once crack  
C2D0 9A2C 4CC9 3EC4 75E1       | smoking hacker at at time 

[-- Attachment #1.2: ada-ltv-knr.patch.bz2 --]
[-- Type: application/octet-stream, Size: 14290 bytes --]

[-- Attachment #2: Type: application/pgp-signature, Size: 230 bytes --]

Re: [patch] change knr function definitions in ada-lang.c, ada-typeprint.c, ada-valprint.c

[Joel Brobecker]

Aidan,

> 2002-07-24  Aidan Skinner <aidan@velvet.net>
> 
> 	* ada-lang.c: Change k&r style function definitions to prototyped
> 	form.
> 	* ada-typeprint.c: Change k&r style function definitions to prototyped
> 	form.
> 	* ada-valprint.c: Change k&r style function definitions to prototyped
> 	form.

I have a few minor comments, and I think I have also found a couple of
little ooopsies.

| + value_from_contents_and_address (struct type* type, char* valaddr, CORE_ADDR address)

This line is more than 80 characters long. I don't know if this is a
requirement in the GDB coding standards (did not find any mention of
it in the GDB internal documentation), but I personally prefer it when
long lines are broken up. Is there a consensus on this topic?

Same comment for the following functions:

  [in ada-lang.c]
    - ada_update_initial_language
    - ada_lookup_struct_elt_type
    - can_discrim_bound
    - ada_value_ptr_subscript
    - ada_array_bound_from_type
    - ada_resolve_subexp
    - ada_convert_actuals
    - ada_lookup_partial_symbol
    - add_symbols_from_enclosing_procs
    - ada_lookup_symbol

  [in ada-typeprint.c]
    - ada_typedef_print
    - print_range_bound
    - print_dynamic_range_bound
    - print_array_type
    - print_choices
    - print_record_type

| +ada_lookup_partial_symbol (struct partial_symtab *pst, const char *name, int global, namespace_enumnamespace, int wild)

There is a space missing between namespace_enum and namespace.

| -ada_array_element_type (type, nindices)
| -     struct type* type;
| -     int nindices;
| +ada_array_element_type (struct btype* type, int nindices)

Is the change from "struct type" to "struct btype" intended?

-- 
Joel

Re: [patch] change knr function definitions in ada-lang.c, ada-typeprint.c, ada-valprint.c

[Andrew Cagney]

> Aidan,
> 
> 
>> 2002-07-24  Aidan Skinner <aidan@velvet.net>
>> 
>> 	* ada-lang.c: Change k&r style function definitions to prototyped
>> 	form.
>> 	* ada-typeprint.c: Change k&r style function definitions to prototyped
>> 	form.
>> 	* ada-valprint.c: Change k&r style function definitions to prototyped
>> 	form.
> 
> 
> I have a few minor comments, and I think I have also found a couple of
> little ooopsies.
> 
> | + value_from_contents_and_address (struct type* type, char* valaddr, CORE_ADDR address)
> 
> This line is more than 80 characters long. I don't know if this is a
> requirement in the GDB coding standards (did not find any mention of
> it in the GDB internal documentation), but I personally prefer it when
> long lines are broken up. Is there a consensus on this topic?

Such indentation is defined by the output of the script 
``gdb_indent.sh'' (if your wondering, gdb_indent.sh keeps things to less 
then 80 characters).

I think here Aidan did the right thing (minus what look like tipo's :-) 
by just fixing parameterizing.  A separate gdb_indent.sh commit can 
resolve any indentation problems.

Adian,

Thinking about where you're at, I think it makes sense for you to commit 
almost all the Makefile.in changes.  Just leave out the tweak that will 
cause a build to compile / link the ada*.c files.  I think this means 
everything (the dependency rules, the source file update, macro 
definitions) but the change adding the .o files to COMMON_OBS.

enjoy,
Andrew

Re: [patch] change knr function definitions in ada-lang.c, ada-typeprint.c, ada-valprint.c

[Aidan Skinner]

On Thu, Jul 25, 2002 at 01:46:51PM -0400, Andrew Cagney wrote

> I think here Aidan did the right thing (minus what look like tipo's :-) 
> by just fixing parameterizing.  A separate gdb_indent.sh commit can 
> resolve any indentation problems.

I'm going to deal with the indentation next. Email coming up with a
patch to fix the tipos and nuke a couple of grep ^func problems.

> Thinking about where you're at, I think it makes sense for you to commit 
> almost all the Makefile.in changes.  Just leave out the tweak that will 

OK. 

- Aidan

-- 
aidan@velvet.net  http://www.velvet.net/~aidan/  aim:aidans42
finger for pgp key fingerprint |- - - - - - - - - - - - - - - - -
01AA 1594 2DB0 09E3 B850       | Marklar Domination, one marklar 
C2D0 9A2C 4CC9 3EC4 75E1       | smoking marklar at at time