From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24767 invoked by alias); 25 Jul 2002 17:46:53 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 24752 invoked from network); 25 Jul 2002 17:46:51 -0000 Received: from unknown (HELO localhost.redhat.com) (216.138.202.10) by sources.redhat.com with SMTP; 25 Jul 2002 17:46:51 -0000 Received: from ges.redhat.com (localhost [127.0.0.1]) by localhost.redhat.com (Postfix) with ESMTP id 3F72E3E0D; Thu, 25 Jul 2002 13:46:51 -0400 (EDT) Message-ID: <3D40398B.6050405@ges.redhat.com> Date: Thu, 25 Jul 2002 11:47:00 -0000 From: Andrew Cagney User-Agent: Mozilla/5.0 (X11; U; NetBSD macppc; en-US; rv:1.0.0) Gecko/20020708 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Joel Brobecker , Aidan Skinner Cc: gdb-patches@sources.redhat.com Subject: Re: [patch] change knr function definitions in ada-lang.c, ada-typeprint.c, ada-valprint.c References: <20020725021316.C10346@velvet.net> <20020725064127.GA683@gnat.com> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2002-07/txt/msg00512.txt.bz2 > Aidan, > > >> 2002-07-24 Aidan Skinner >> >> * ada-lang.c: Change k&r style function definitions to prototyped >> form. >> * ada-typeprint.c: Change k&r style function definitions to prototyped >> form. >> * ada-valprint.c: Change k&r style function definitions to prototyped >> form. > > > I have a few minor comments, and I think I have also found a couple of > little ooopsies. > > | + value_from_contents_and_address (struct type* type, char* valaddr, CORE_ADDR address) > > This line is more than 80 characters long. I don't know if this is a > requirement in the GDB coding standards (did not find any mention of > it in the GDB internal documentation), but I personally prefer it when > long lines are broken up. Is there a consensus on this topic? Such indentation is defined by the output of the script ``gdb_indent.sh'' (if your wondering, gdb_indent.sh keeps things to less then 80 characters). I think here Aidan did the right thing (minus what look like tipo's :-) by just fixing parameterizing. A separate gdb_indent.sh commit can resolve any indentation problems. Adian, Thinking about where you're at, I think it makes sense for you to commit almost all the Makefile.in changes. Just leave out the tweak that will cause a build to compile / link the ada*.c files. I think this means everything (the dependency rules, the source file update, macro definitions) but the change adding the .o files to COMMON_OBS. enjoy, Andrew