Re: [patch] change knr function definitions in ada-lang.c, ada-typeprint.c, ada-valprint.c

[Andrew Cagney <ac131313@ges.redhat.com>]

> Aidan,
> 
> 
>> 2002-07-24  Aidan Skinner <aidan@velvet.net>
>> 
>> 	* ada-lang.c: Change k&r style function definitions to prototyped
>> 	form.
>> 	* ada-typeprint.c: Change k&r style function definitions to prototyped
>> 	form.
>> 	* ada-valprint.c: Change k&r style function definitions to prototyped
>> 	form.
> 
> 
> I have a few minor comments, and I think I have also found a couple of
> little ooopsies.
> 
> | + value_from_contents_and_address (struct type* type, char* valaddr, CORE_ADDR address)
> 
> This line is more than 80 characters long. I don't know if this is a
> requirement in the GDB coding standards (did not find any mention of
> it in the GDB internal documentation), but I personally prefer it when
> long lines are broken up. Is there a consensus on this topic?

Such indentation is defined by the output of the script 
``gdb_indent.sh'' (if your wondering, gdb_indent.sh keeps things to less 
then 80 characters).

I think here Aidan did the right thing (minus what look like tipo's :-) 
by just fixing parameterizing.  A separate gdb_indent.sh commit can 
resolve any indentation problems.

Adian,

Thinking about where you're at, I think it makes sense for you to commit 
almost all the Makefile.in changes.  Just leave out the tweak that will 
cause a build to compile / link the ada*.c files.  I think this means 
everything (the dependency rules, the source file update, macro 
definitions) but the change adding the .o files to COMMON_OBS.

enjoy,
Andrew