From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19693 invoked by alias); 25 Jul 2002 06:41:30 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 19683 invoked from network); 25 Jul 2002 06:41:28 -0000 Received: from unknown (HELO takamaka.act-europe.fr) (142.179.108.108) by sources.redhat.com with SMTP; 25 Jul 2002 06:41:28 -0000 Received: by takamaka.act-europe.fr (Postfix, from userid 507) id 83FABD2CBD; Wed, 24 Jul 2002 23:41:27 -0700 (PDT) Date: Thu, 25 Jul 2002 03:13:00 -0000 From: Joel Brobecker To: Aidan Skinner Cc: gdb-patches@sources.redhat.com Subject: Re: [patch] change knr function definitions in ada-lang.c, ada-typeprint.c, ada-valprint.c Message-ID: <20020725064127.GA683@gnat.com> References: <20020725021316.C10346@velvet.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20020725021316.C10346@velvet.net> User-Agent: Mutt/1.4i X-SW-Source: 2002-07/txt/msg00505.txt.bz2 Aidan, > 2002-07-24 Aidan Skinner > > * ada-lang.c: Change k&r style function definitions to prototyped > form. > * ada-typeprint.c: Change k&r style function definitions to prototyped > form. > * ada-valprint.c: Change k&r style function definitions to prototyped > form. I have a few minor comments, and I think I have also found a couple of little ooopsies. | + value_from_contents_and_address (struct type* type, char* valaddr, CORE_ADDR address) This line is more than 80 characters long. I don't know if this is a requirement in the GDB coding standards (did not find any mention of it in the GDB internal documentation), but I personally prefer it when long lines are broken up. Is there a consensus on this topic? Same comment for the following functions: [in ada-lang.c] - ada_update_initial_language - ada_lookup_struct_elt_type - can_discrim_bound - ada_value_ptr_subscript - ada_array_bound_from_type - ada_resolve_subexp - ada_convert_actuals - ada_lookup_partial_symbol - add_symbols_from_enclosing_procs - ada_lookup_symbol [in ada-typeprint.c] - ada_typedef_print - print_range_bound - print_dynamic_range_bound - print_array_type - print_choices - print_record_type | +ada_lookup_partial_symbol (struct partial_symtab *pst, const char *name, int global, namespace_enumnamespace, int wild) There is a space missing between namespace_enum and namespace. | -ada_array_element_type (type, nindices) | - struct type* type; | - int nindices; | +ada_array_element_type (struct btype* type, int nindices) Is the change from "struct type" to "struct btype" intended? -- Joel