Testsuite tweak - properly bail out of asm-source.exp

Testsuite tweak - properly bail out of asm-source.exp

[Zack Weinberg]

If asm-source.exp detects that there is no support for assembly source
debugging on the selected target, it issues a warning to that effect:

if { "${asm-arch}" == "" } {
    gdb_suppress_entire_file "Assembly source test -- not implemented for this t
arget."
}

but then it goes on to run the tests anyway, and they all fail, often
with nasty error messages too.  Looking a bit lower, I see that one is
supposed to return after calling gdb_suppress_entire_file.  This patch
just adds a return to the if block.

zw

	* gdb.asm/asm-source.exp: Return after calling
	gdb_suppress_entire_file.

===================================================================
Index: testsuite/gdb.asm/asm-source.exp
--- testsuite/gdb.asm/asm-source.exp	8 Apr 2002 00:01:06 -0000	1.21
+++ testsuite/gdb.asm/asm-source.exp	18 Apr 2002 01:29:59 -0000
@@ -65,6 +65,7 @@ if [istarget "xstormy16-*-*"] then {
 }
 if { "${asm-arch}" == "" } {
     gdb_suppress_entire_file "Assembly source test -- not implemented for this target."
+    return;
 }
 
 # Watch out, we are invoking the assembler, but the testsuite sets multilib

Re: Testsuite tweak - properly bail out of asm-source.exp

[Andrew Cagney]

See:

2001-11-09  Andrew Cagney  <ac131313@redhat.com>

* gdb.asm/asm-source.exp: Supress file, instead of skip, when not
implemented.

and, especially, the number of tests that have been contributed since 
that change went in.

enjoy,
Andrew


> If asm-source.exp detects that there is no support for assembly source
> debugging on the selected target, it issues a warning to that effect:
> 
> if { "${asm-arch}" == "" } {
>     gdb_suppress_entire_file "Assembly source test -- not implemented for this t
> arget."
> }
> 
> but then it goes on to run the tests anyway, and they all fail, often
> with nasty error messages too.  Looking a bit lower, I see that one is
> supposed to return after calling gdb_suppress_entire_file.  This patch
> just adds a return to the if block.

Re: Testsuite tweak - properly bail out of asm-source.exp

[Zack Weinberg]

On Wed, Apr 17, 2002 at 10:59:07PM -0400, Andrew Cagney wrote:
> See:
> 
> 2001-11-09  Andrew Cagney  <ac131313@redhat.com>
> 
> * gdb.asm/asm-source.exp: Supress file, instead of skip, when not
> implemented.
> 
> and, especially, the number of tests that have been contributed since 
> that change went in.

Okay, if it was deliberately done like that, I withdraw the patch

zw

Re: Testsuite tweak - properly bail out of asm-source.exp

[Michael Snyder]

Zack Weinberg wrote:
> 
> On Wed, Apr 17, 2002 at 10:59:07PM -0400, Andrew Cagney wrote:
> > See:
> >
> > 2001-11-09  Andrew Cagney  <ac131313@redhat.com>
> >
> > * gdb.asm/asm-source.exp: Supress file, instead of skip, when not
> > implemented.
> >
> > and, especially, the number of tests that have been contributed since
> > that change went in.
> 
> Okay, if it was deliberately done like that, I withdraw the patch

The Maintainer moves in mysterious ways...   ;-)

Re: Testsuite tweak - properly bail out of asm-source.exp

[Fernando Nasser]

Zack Weinberg wrote:
> 
> On Wed, Apr 17, 2002 at 10:59:07PM -0400, Andrew Cagney wrote:
> > See:
> >
> > 2001-11-09  Andrew Cagney  <ac131313@redhat.com>
> >
> > * gdb.asm/asm-source.exp: Supress file, instead of skip, when not
> > implemented.
> >
> > and, especially, the number of tests that have been contributed since
> > that change went in.
> 
> Okay, if it was deliberately done like that, I withdraw the patch
> 

ACK.  

But thanks for caring and spending the time to send the patch in.

Regards,
Fernando

-- 
Fernando Nasser
Red Hat Canada Ltd.                     E-Mail:  fnasser@redhat.com
2323 Yonge Street, Suite #300
Toronto, Ontario   M4P 2C9