Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Zack Weinberg <zack@codesourcery.com>
To: gdb-patches@sources.redhat.com
Subject: Testsuite tweak - properly bail out of asm-source.exp
Date: Wed, 17 Apr 2002 18:31:00 -0000	[thread overview]
Message-ID: <20020418013121.GE30952@codesourcery.com> (raw)

If asm-source.exp detects that there is no support for assembly source
debugging on the selected target, it issues a warning to that effect:

if { "${asm-arch}" == "" } {
    gdb_suppress_entire_file "Assembly source test -- not implemented for this t
arget."
}

but then it goes on to run the tests anyway, and they all fail, often
with nasty error messages too.  Looking a bit lower, I see that one is
supposed to return after calling gdb_suppress_entire_file.  This patch
just adds a return to the if block.

zw

	* gdb.asm/asm-source.exp: Return after calling
	gdb_suppress_entire_file.

===================================================================
Index: testsuite/gdb.asm/asm-source.exp
--- testsuite/gdb.asm/asm-source.exp	8 Apr 2002 00:01:06 -0000	1.21
+++ testsuite/gdb.asm/asm-source.exp	18 Apr 2002 01:29:59 -0000
@@ -65,6 +65,7 @@ if [istarget "xstormy16-*-*"] then {
 }
 if { "${asm-arch}" == "" } {
     gdb_suppress_entire_file "Assembly source test -- not implemented for this target."
+    return;
 }
 
 # Watch out, we are invoking the assembler, but the testsuite sets multilib


             reply	other threads:[~2002-04-18  1:31 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-04-17 18:31 Zack Weinberg [this message]
2002-04-17 19:59 ` Andrew Cagney
2002-04-18 10:40   ` Zack Weinberg
2002-04-18 11:10     ` Michael Snyder
2002-04-18 11:35     ` Fernando Nasser

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20020418013121.GE30952@codesourcery.com \
    --to=zack@codesourcery.com \
    --cc=gdb-patches@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox