From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-14357-listarch-gdb-patches=sourceware.cygnus.com@sources.redhat.com>
Received: (qmail 18722 invoked by alias); 18 Apr 2002 01:31:24 -0000
Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm
Precedence: bulk
List-Subscribe: <mailto:gdb-patches-subscribe@sources.redhat.com>
List-Archive: <http://sources.redhat.com/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sources.redhat.com>
List-Help: <mailto:gdb-patches-help@sources.redhat.com>, <http://sources.redhat.com/ml/#faqs>
Sender: gdb-patches-owner@sources.redhat.com
Received: (qmail 18705 invoked from network); 18 Apr 2002 01:31:21 -0000
Received: from unknown (HELO taltos.codesourcery.com) (66.92.14.122)
  by sources.redhat.com with SMTP; 18 Apr 2002 01:31:21 -0000
Received: from zack by taltos.codesourcery.com with local (Exim 3.35 #1 (Debian))
	id 16y0ld-0000EN-00
	for <gdb-patches@sources.redhat.com>; Wed, 17 Apr 2002 18:31:21 -0700
Date: Wed, 17 Apr 2002 18:31:00 -0000
To: gdb-patches@sources.redhat.com
Subject: Testsuite tweak - properly bail out of asm-source.exp
Message-ID: <20020418013121.GE30952@codesourcery.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
User-Agent: Mutt/1.3.28i
From: Zack Weinberg <zack@codesourcery.com>
X-SW-Source: 2002-04/txt/msg00578.txt.bz2

If asm-source.exp detects that there is no support for assembly source
debugging on the selected target, it issues a warning to that effect:

if { "${asm-arch}" == "" } {
    gdb_suppress_entire_file "Assembly source test -- not implemented for this t
arget."
}

but then it goes on to run the tests anyway, and they all fail, often
with nasty error messages too.  Looking a bit lower, I see that one is
supposed to return after calling gdb_suppress_entire_file.  This patch
just adds a return to the if block.

zw

	* gdb.asm/asm-source.exp: Return after calling
	gdb_suppress_entire_file.

===================================================================
Index: testsuite/gdb.asm/asm-source.exp
--- testsuite/gdb.asm/asm-source.exp	8 Apr 2002 00:01:06 -0000	1.21
+++ testsuite/gdb.asm/asm-source.exp	18 Apr 2002 01:29:59 -0000
@@ -65,6 +65,7 @@ if [istarget "xstormy16-*-*"] then {
 }
 if { "${asm-arch}" == "" } {
     gdb_suppress_entire_file "Assembly source test -- not implemented for this target."
+    return;
 }
 
 # Watch out, we are invoking the assembler, but the testsuite sets multilib