From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30866 invoked by alias); 18 Apr 2002 02:59:01 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 30835 invoked from network); 18 Apr 2002 02:58:58 -0000 Received: from unknown (HELO localhost.redhat.com) (24.112.240.27) by sources.redhat.com with SMTP; 18 Apr 2002 02:58:58 -0000 Received: from cygnus.com (localhost [127.0.0.1]) by localhost.redhat.com (Postfix) with ESMTP id F1E123D0C; Wed, 17 Apr 2002 22:59:07 -0400 (EDT) Message-ID: <3CBE367B.5060504@cygnus.com> Date: Wed, 17 Apr 2002 19:59:00 -0000 From: Andrew Cagney User-Agent: Mozilla/5.0 (X11; U; NetBSD macppc; en-US; rv:0.9.9) Gecko/20020328 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Zack Weinberg Cc: gdb-patches@sources.redhat.com Subject: Re: Testsuite tweak - properly bail out of asm-source.exp References: <20020418013121.GE30952@codesourcery.com> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2002-04/txt/msg00581.txt.bz2 See: 2001-11-09 Andrew Cagney * gdb.asm/asm-source.exp: Supress file, instead of skip, when not implemented. and, especially, the number of tests that have been contributed since that change went in. enjoy, Andrew > If asm-source.exp detects that there is no support for assembly source > debugging on the selected target, it issues a warning to that effect: > > if { "${asm-arch}" == "" } { > gdb_suppress_entire_file "Assembly source test -- not implemented for this t > arget." > } > > but then it goes on to run the tests anyway, and they all fail, often > with nasty error messages too. Looking a bit lower, I see that one is > supposed to return after calling gdb_suppress_entire_file. This patch > just adds a return to the if block.