Your patch to list.exp

Your patch to list.exp

[Daniel Jacobowitz]

I just saw this on gdb-cvs.  Was it ever on gdb-patches?  I don't recall
seeing it at least.

Is it actually correct if you have debugging information for _start
available?  If we connect and are in a known line, presumably we will list
there instead.

revision 1.5
date: 2002/03/26 00:36:07;  author: fnf;  state: Exp;  lines: +2 -7
        2002-03-25  Fred Fish  <fnf@redhat.com>
        * gdb.base/list.exp: This test works on remote targets so remove
        the short circuit for remote targets.  Update copyright.
----------------------------
revision 1.4
date: 2002/02/14 06:25:18;  author: drow;  state: Exp;  lines: +1 -1
2002-02-14  Daniel Jacobowitz  <drow@mvista.com>

        * gdb.base/a2-run.exp: Check for a remote target properly.
        * gdb.base/annota1.exp: Likewise.
        * gdb.base/list.exp: Likewise.
        * gdb.base/reread.exp: Likewise.
        * gdb.base/scope.exp: Likewise.
        * gdb.base/shlib-call.exp: Likewise.
        * gdb.base/term.exp: Likewise.
        * gdb.c++/annota2.exp: Likewise.

-- 
Daniel Jacobowitz                           Carnegie Mellon University
MontaVista Software                         Debian GNU/Linux Developer

Re: Your patch to list.exp

[Fred Fish]

> I just saw this on gdb-cvs.  Was it ever on gdb-patches?  I don't recall
> seeing it at least.

Yes, here is the URL to the original post:

  http://sources.redhat.com/ml/gdb-patches/2002-01/msg00115.html

There was also a reply from Kevin Buettner <kevinb@redhat.com> which
I got in email but which doesn't appear to be in the gdb-patches
list:

  I just came across this myself.  I agree with Michael and Fred that the
  isnative test is bogus.

  Kevin

> Is it actually correct if you have debugging information for _start
> available?  If we connect and are in a known line, presumably we will list
> there instead.

Hmm, don't know.  I do know that I originally found this problem with
an actual remote target for which the patch is OK.

-Fred

Re: Your patch to list.exp

[Daniel Jacobowitz]

On Mon, Mar 25, 2002 at 09:12:10PM -0700, Fred Fish wrote:
> > I just saw this on gdb-cvs.  Was it ever on gdb-patches?  I don't recall
> > seeing it at least.
> 
> Yes, here is the URL to the original post:
> 
>   http://sources.redhat.com/ml/gdb-patches/2002-01/msg00115.html
> 
> There was also a reply from Kevin Buettner <kevinb@redhat.com> which
> I got in email but which doesn't appear to be in the gdb-patches
> list:

> 
>   I just came across this myself.  I agree with Michael and Fred that the
>   isnative test is bogus.
> 
>   Kevin

Oh yes, I remember now.  Thanks.

> > Is it actually correct if you have debugging information for _start
> > available?  If we connect and are in a known line, presumably we will list
> > there instead.
> 
> Hmm, don't know.  I do know that I originally found this problem with
> an actual remote target for which the patch is OK.

I just verified that the test fails if you have debugging info for
_start.  In light of that, please consider reverting this (and maybe an
informative comment...).

-- 
Daniel Jacobowitz                           Carnegie Mellon University
MontaVista Software                         Debian GNU/Linux Developer

Re: Your patch to list.exp

[Fernando Nasser]

Daniel Jacobowitz wrote:
> 
> On Mon, Mar 25, 2002 at 09:12:10PM -0700, Fred Fish wrote:
> > > I just saw this on gdb-cvs.  Was it ever on gdb-patches?  I don't recall
> > > seeing it at least.
> >
> > Yes, here is the URL to the original post:
> >
> >   http://sources.redhat.com/ml/gdb-patches/2002-01/msg00115.html
> >

I can only see a reply from Michael Snyder.

Can you point me to where the discussion continued?

Regards,
Fernando

> > There was also a reply from Kevin Buettner <kevinb@redhat.com> which
> > I got in email but which doesn't appear to be in the gdb-patches
> > list:
> 
> >
> >   I just came across this myself.  I agree with Michael and Fred that the
> >   isnative test is bogus.
> >
> >   Kevin
> 
> Oh yes, I remember now.  Thanks.
> 

I don't.  It seems that I was not copied on that one.


-- 
Fernando Nasser
Red Hat Canada Ltd.                     E-Mail:  fnasser@redhat.com
2323 Yonge Street, Suite #300
Toronto, Ontario   M4P 2C9

Re: Your patch to list.exp

[Fernando Nasser]

Daniel Jacobowitz wrote:
> 
> > Hmm, don't know.  I do know that I originally found this problem with
> > an actual remote target for which the patch is OK.
> 
> I just verified that the test fails if you have debugging info for
> _start.  In light of that, please consider reverting this (and maybe an
> informative comment...).
> 

It seems this test may eventually work with a remote target, but it is
only supposed to work always with native targets.
I guess the only thing that we can do is to run it only for natives.

I agree that the patch must be reverted and that a comment is a good
idea.

Thanks for catching this Daniel.

Regards,
Fernando

-- 
Fernando Nasser
Red Hat Canada Ltd.                     E-Mail:  fnasser@redhat.com
2323 Yonge Street, Suite #300
Toronto, Ontario   M4P 2C9