Re: PATCH: --args

Re: PATCH: --args

[Fernando Nasser]

> Andrew> Just check with Fernando and Elena.
> 
> Ok.
> 

OK with me.  Elena?

-- 
Fernando Nasser
Red Hat Canada Ltd.                     E-Mail:  fnasser@redhat.com
2323 Yonge Street, Suite #300
Toronto, Ontario   M4P 2C9

Re: PATCH: --args

[Elena Zannoni]

Tom Tromey writes:
 > >>>>> "Andrew" == Andrew Cagney <ac131313@cygnus.com> writes:
 > 
 > Tom> +f::CONSTRUCT_INFERIOR_ARGUMENTS:char *:construct_inferior_arguments:int argc, char **argv:argc, argv:::construct_inferior_arguments::0
 > 
 > Andrew> Could you please tweek this to be:
 > Andrew> 	m:::char *:....
 > Andrew> instead of ``f:''.
 > 
 > Done.
 > It wasn't clear to me when I would use `f' or `m', so I picked
 > arbitrarily.
 > 
 > >> +      n = CONSTRUCT_INFERIOR_ARGUMENTS (inferior_argc, inferior_argv);
 > 
 > Andrew> the above will also need to be tweeked to be:
 > Andrew> 	n = gdbarch_construct_inferior_arguments (current_gdbarch, ...);
 > 
 > Also done.
 > Thanks.
 > 
 > Andrew> Just check with Fernando and Elena.
 > 
 > Ok.

main.c changes are ok.

Elena


 > 
 > Tom

Re: PATCH: --args

[Tom Tromey]

>>>>> "Elena" == Elena Zannoni <ezannoni@cygnus.com> writes:

Elena> main.c changes are ok.

Thanks!  I think that's the last approval I need.  I'll check the
patch in this evening.

I assume I should close the corresponding PRs.  What is the gdb
process for this?  Do I simply close them?  Put them in `feedback'?
Or what?

Tom

Re: PATCH: --args

[Andrew Cagney]

>>>>>> "Elena" == Elena Zannoni <ezannoni@cygnus.com> writes:
> 
> 
> Elena> main.c changes are ok.
> 
> Thanks!  I think that's the last approval I need.  I'll check the
> patch in this evening.
> 
> I assume I should close the corresponding PRs.  What is the gdb
> process for this?  Do I simply close them?  Put them in `feedback'?
> Or what?

To be honest.  I don't think we have one.....  I do either depending on 
what the PR is.  If it is one of my ``enhancement requests'' just close it.

Andrew

Re: PATCH: --args => build failure

[Pierre Muller]

At 00:13 22/11/2001 , Tom Tromey a écrit:
> >>>>> "Elena" == Elena Zannoni <ezannoni@cygnus.com> writes:
>
>Elena> main.c changes are ok.
>
>Thanks!  I think that's the last approval I need.  I'll check the
>patch in this evening.
>
>I assume I should close the corresponding PRs.  What is the gdb
>process for this?  Do I simply close them?  Put them in `feedback'?
>Or what?

   Your patch does create a build failure for cygwin target.

   This target apparently does not use fork-child.c
(at least it is not included into the libgdb.a)
and thus I get the following error when I try to build the current main CVS 
tree:

$ make
rm -f gdb.exe
gcc -g -O2         -o gdb.exe \
main.o libgdb.a cli-decode.o cli-script.o cli-cmds.o cli-setshow.o 
cli-utils.o m
i-out.o mi-console.o mi-cmds.o mi-cmd-var.o mi-cmd-break.o mi-cmd-stack.o 
mi-cmd
-disas.o mi-main.o mi-parse.o mi-getopt.o    ../bfd/libbfd.a 
../readline/libread
line.a ../opcodes/libopcodes.a ./../intl/libintl.a ../libiberty/libiberty.a `if
test -r ../libtermcap/libtermcap.a; then echo ../libtermcap/libtermcap.a; 
else e
cho -ltermcap; fi`     -lm  ../libiberty/libiberty.a -luser32 -limagehlp\

libgdb.a(gdbarch.o): In function `gdbarch_alloc':
/home/muller/gdb/build/gdb/../../src/gdb/gdbarch.c:509: undefined reference 
to `
construct_inferior_arguments'
/home/muller/gdb/build/gdb/../../src/gdb/gdbarch.c:482: undefined reference 
to `
construct_inferior_arguments'
collect2: ld returned 1 exit status
make: *** [gdb.exe] Error 1



Pierre Muller
Institut Charles Sadron
6,rue Boussingault
F 67083 STRASBOURG CEDEX (France)
mailto:muller@ics.u-strasbg.fr
Phone : (33)-3-88-41-40-07  Fax : (33)-3-88-41-40-99

Re: PATCH: --args => build failure

[Pierre Muller]

At 12:17 22/11/2001 , Pierre Muller a écrit:
>At 00:13 22/11/2001 , Tom Tromey a écrit:
>> >>>>> "Elena" == Elena Zannoni <ezannoni@cygnus.com> writes:
>>
>>Elena> main.c changes are ok.
>>
>>Thanks!  I think that's the last approval I need.  I'll check the
>>patch in this evening.
>>
>>I assume I should close the corresponding PRs.  What is the gdb
>>process for this?  Do I simply close them?  Put them in `feedback'?
>>Or what?
>
>   Your patch does create a build failure for cygwin target.
>
>   This target apparently does not use fork-child.c
>(at least it is not included into the libgdb.a)
>and thus I get the following error when I try to build the current main 
>CVS tree:
>
>$ make
>rm -f gdb.exe
>gcc -g -O2         -o gdb.exe \
>main.o libgdb.a cli-decode.o cli-script.o cli-cmds.o cli-setshow.o 
>cli-utils.o m
>i-out.o mi-console.o mi-cmds.o mi-cmd-var.o mi-cmd-break.o mi-cmd-stack.o 
>mi-cmd
>-disas.o mi-main.o mi-parse.o mi-getopt.o    ../bfd/libbfd.a 
>../readline/libread
>line.a ../opcodes/libopcodes.a ./../intl/libintl.a 
>../libiberty/libiberty.a `if
>test -r ../libtermcap/libtermcap.a; then echo ../libtermcap/libtermcap.a; 
>else e
>cho -ltermcap; fi`     -lm  ../libiberty/libiberty.a -luser32 -limagehlp\
>
>libgdb.a(gdbarch.o): In function `gdbarch_alloc':
>/home/muller/gdb/build/gdb/../../src/gdb/gdbarch.c:509: undefined 
>reference to `
>construct_inferior_arguments'
>/home/muller/gdb/build/gdb/../../src/gdb/gdbarch.c:482: undefined 
>reference to `
>construct_inferior_arguments'
>collect2: ld returned 1 exit status
>make: *** [gdb.exe] Error 1

   For you info:
compiling fork-child.o by calling
make fork-child.o
adding fork-child.o to libgdb.a with
ar t libgdb.a fork-child.o
and running make again
seems to be enough to get a new gdb executable.

But I have no real idea where dependency of fork-child file must be added.


Pierre Muller
Institut Charles Sadron
6,rue Boussingault
F 67083 STRASBOURG CEDEX (France)
mailto:muller@ics.u-strasbg.fr
Phone : (33)-3-88-41-40-07  Fax : (33)-3-88-41-40-99

Re: PATCH: --args => build failure

[Pierre Muller]

At 12:39 22/11/2001 , Pierre Muller a écrit:
>At 12:17 22/11/2001 , Pierre Muller a écrit:
>>At 00:13 22/11/2001 , Tom Tromey a écrit:
>>> >>>>> "Elena" == Elena Zannoni <ezannoni@cygnus.com> writes:
>>>
>>>Elena> main.c changes are ok.
>>>
>>>Thanks!  I think that's the last approval I need.  I'll check the
>>>patch in this evening.
>>>
>>>I assume I should close the corresponding PRs.  What is the gdb
>>>process for this?  Do I simply close them?  Put them in `feedback'?
>>>Or what?
>>
>>   Your patch does create a build failure for cygwin target.
>>
>>   This target apparently does not use fork-child.c
>>(at least it is not included into the libgdb.a)
>>and thus I get the following error when I try to build the current main 
>>CVS tree:
>>
>>$ make
>>rm -f gdb.exe
>>gcc -g -O2         -o gdb.exe \
>>main.o libgdb.a cli-decode.o cli-script.o cli-cmds.o cli-setshow.o 
>>cli-utils.o m
>>i-out.o mi-console.o mi-cmds.o mi-cmd-var.o mi-cmd-break.o mi-cmd-stack.o 
>>mi-cmd
>>-disas.o mi-main.o mi-parse.o mi-getopt.o    ../bfd/libbfd.a 
>>../readline/libread
>>line.a ../opcodes/libopcodes.a ./../intl/libintl.a 
>>../libiberty/libiberty.a `if
>>test -r ../libtermcap/libtermcap.a; then echo ../libtermcap/libtermcap.a; 
>>else e
>>cho -ltermcap; fi`     -lm  ../libiberty/libiberty.a -luser32 -limagehlp\
>>
>>libgdb.a(gdbarch.o): In function `gdbarch_alloc':
>>/home/muller/gdb/build/gdb/../../src/gdb/gdbarch.c:509: undefined 
>>reference to `
>>construct_inferior_arguments'
>>/home/muller/gdb/build/gdb/../../src/gdb/gdbarch.c:482: undefined 
>>reference to `
>>construct_inferior_arguments'
>>collect2: ld returned 1 exit status
>>make: *** [gdb.exe] Error 1
>
>   For you info:
>compiling fork-child.o by calling
>make fork-child.o
>adding fork-child.o to libgdb.a with
>ar t libgdb.a fork-child.o
>and running make again
>seems to be enough to get a new gdb executable.
>
>But I have no real idea where dependency of fork-child file must be added.

  Maybe the best solution would be to move this command into a file that is 
loaded for
all targets, what about infrun.c ?


Pierre Muller
Institut Charles Sadron
6,rue Boussingault
F 67083 STRASBOURG CEDEX (France)
mailto:muller@ics.u-strasbg.fr
Phone : (33)-3-88-41-40-07  Fax : (33)-3-88-41-40-99

Re: PATCH: --args => build failure

[Tom Tromey]

>>>>> "Pierre" == Pierre Muller <muller@cerbere.u-strasbg.fr> writes:

Pierre> Your patch does create a build failure for cygwin target.

Sorry about that.  I'll try to fix it this weekend.
One fix would be to write the correct quoting function for Windows.
Would you be able to test such a function if I wrote it?

Tom

Re: PATCH: --args => build failure

[Pierre Muller]

At 14:19 22/11/01 -0700, Tom Tromey wrote:
>>>>>> "Pierre" == Pierre Muller <muller@cerbere.u-strasbg.fr> writes:
>
>Pierre> Your patch does create a build failure for cygwin target.
>
>Sorry about that.  I'll try to fix it this weekend.
>One fix would be to write the correct quoting function for Windows.
>Would you be able to test such a function if I wrote it?

  But that would only fix the problem for one target,
don't you think that my last proposal, to
move the code to infrun.c code is more
general ?

  This does not exclude the fact that a separate version to parse the args
might be needed for cygwin target, but I 
think that the build failure presently concerns all
targets that do not include fork-child.o in NATDEPFILES !

Re: PATCH: --args => build failure

[Christopher Faylor]

On Thu, Nov 22, 2001 at 02:19:26PM -0700, Tom Tromey wrote:
>>>>>> "Pierre" == Pierre Muller <muller@cerbere.u-strasbg.fr> writes:
>
>Pierre> Your patch does create a build failure for cygwin target.
>
>Sorry about that.  I'll try to fix it this weekend.
>One fix would be to write the correct quoting function for Windows.
>Would you be able to test such a function if I wrote it?

Cygwin doesn't need any special quoting handling.  There is a patch
pending which will cause cygwin to use /bin/sh to invoke a subprocess.
We're just waiting for an assignment.

cgf

Re: PATCH: --args => build failure

[Michael Snyder]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain, Size: 697 bytes --]

Pierre Muller wrote:
> 
> At 00:13 22/11/2001 , Tom Tromey a écrit:
> > >>>>> "Elena" == Elena Zannoni <ezannoni@cygnus.com> writes:
> >
> >Elena> main.c changes are ok.
> >
> >Thanks!  I think that's the last approval I need.  I'll check the
> >patch in this evening.
> >
> >I assume I should close the corresponding PRs.  What is the gdb
> >process for this?  Do I simply close them?  Put them in `feedback'?
> >Or what?
> 
>    Your patch does create a build failure for cygwin target.
> 
>    This target apparently does not use fork-child.c
> (at least it is not included into the libgdb.a)

I would suspect that any non-native (eg. embedded) gdb
would fail to build for the same reason.

Re: PATCH: --args => build failure

[Michael Snyder]

Pierre Muller wrote:
> 
> At 00:13 22/11/2001 , Tom Tromey a écrit:
> > >>>>> "Elena" == Elena Zannoni <ezannoni@cygnus.com> writes:
> >
> >Elena> main.c changes are ok.
> >
> >Thanks!  I think that's the last approval I need.  I'll check the
> >patch in this evening.
> >
> >I assume I should close the corresponding PRs.  What is the gdb
> >process for this?  Do I simply close them?  Put them in `feedback'?
> >Or what?
> 
>    Your patch does create a build failure for cygwin target.
> 
>    This target apparently does not use fork-child.c
> (at least it is not included into the libgdb.a)

I would suspect that any non-native (eg. embedded) gdb
would fail to build for the same reason.

Re: PATCH: --args => build failure

[Christopher Faylor]

On Mon, Nov 26, 2001 at 02:58:45PM -0800, Michael Snyder wrote:
>Pierre Muller wrote:
>> 
>> At 00:13 22/11/2001 , Tom Tromey a ?crit:
>> > >>>>> "Elena" == Elena Zannoni <ezannoni@cygnus.com> writes:
>> >
>> >Elena> main.c changes are ok.
>> >
>> >Thanks!  I think that's the last approval I need.  I'll check the
>> >patch in this evening.
>> >
>> >I assume I should close the corresponding PRs.  What is the gdb
>> >process for this?  Do I simply close them?  Put them in `feedback'?
>> >Or what?
>> 
>>    Your patch does create a build failure for cygwin target.
>> 
>>    This target apparently does not use fork-child.c
>> (at least it is not included into the libgdb.a)
>
>I would suspect that any non-native (eg. embedded) gdb
>would fail to build for the same reason.

FWIW, I moved the function to infcmd.c in my sandbox.

cgf

Re: PATCH: --args => build failure

[Christopher Faylor]

On Mon, Nov 26, 2001 at 02:58:45PM -0800, Michael Snyder wrote:
>Pierre Muller wrote:
>> 
>> At 00:13 22/11/2001 , Tom Tromey a ?crit:
>> > >>>>> "Elena" == Elena Zannoni <ezannoni@cygnus.com> writes:
>> >
>> >Elena> main.c changes are ok.
>> >
>> >Thanks!  I think that's the last approval I need.  I'll check the
>> >patch in this evening.
>> >
>> >I assume I should close the corresponding PRs.  What is the gdb
>> >process for this?  Do I simply close them?  Put them in `feedback'?
>> >Or what?
>> 
>>    Your patch does create a build failure for cygwin target.
>> 
>>    This target apparently does not use fork-child.c
>> (at least it is not included into the libgdb.a)
>
>I would suspect that any non-native (eg. embedded) gdb
>would fail to build for the same reason.

FWIW, I moved the function to infcmd.c in my sandbox.

cgf