From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-10677-listarch-gdb-patches=sourceware.cygnus.com@sources.redhat.com>
Received: (qmail 23183 invoked by alias); 21 Nov 2001 22:10:07 -0000
Mailing-List: contact gdb-patches-help@sourceware.cygnus.com; run by ezmlm
Precedence: bulk
List-Subscribe: <mailto:gdb-patches-subscribe@sources.redhat.com>
List-Archive: <http://sources.redhat.com/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sources.redhat.com>
List-Help: <mailto:gdb-patches-help@sources.redhat.com>, <http://sources.redhat.com/ml/#faqs>
Sender: gdb-patches-owner@sources.redhat.com
Received: (qmail 23128 invoked from network); 21 Nov 2001 22:09:59 -0000
Received: from unknown (HELO cygnus.com) (205.180.230.5)
  by sourceware.cygnus.com with SMTP; 21 Nov 2001 22:09:59 -0000
Received: from rtl.cygnus.com (cse.cygnus.com [205.180.230.236])
	by runyon.cygnus.com (8.8.7-cygnus/8.8.7) with ESMTP id OAA02433;
	Wed, 21 Nov 2001 14:09:55 -0800 (PST)
Received: (from ezannoni@localhost)
	by rtl.cygnus.com (8.11.2/8.11.0) id fALMGEV06136;
	Wed, 21 Nov 2001 17:16:14 -0500
X-Authentication-Warning: krustylu.cygnus.com: ezannoni set sender to ezannoni@cygnus.com using -f
From: Elena Zannoni <ezannoni@cygnus.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Message-ID: <15356.10158.489653.156184@krustylu.cygnus.com>
Date: Thu, 08 Nov 2001 17:15:00 -0000
To: tromey@redhat.com
Cc: gdb-patches@sources.redhat.com
Subject: Re: PATCH: --args
In-Reply-To: <87snbmb9nm.fsf@creche.redhat.com>
References: <873d3mcpcu.fsf@creche.redhat.com>
	<3BED93E7.9000104@cygnus.com>
	<87snbmb9nm.fsf@creche.redhat.com>
X-Mailer: VM 6.97 under Emacs 20.7.1
X-SW-Source: 2001-11/txt/msg00173.txt.bz2

Tom Tromey writes:
 > >>>>> "Andrew" == Andrew Cagney <ac131313@cygnus.com> writes:
 > 
 > Tom> +f::CONSTRUCT_INFERIOR_ARGUMENTS:char *:construct_inferior_arguments:int argc, char **argv:argc, argv:::construct_inferior_arguments::0
 > 
 > Andrew> Could you please tweek this to be:
 > Andrew> 	m:::char *:....
 > Andrew> instead of ``f:''.
 > 
 > Done.
 > It wasn't clear to me when I would use `f' or `m', so I picked
 > arbitrarily.
 > 
 > >> +      n = CONSTRUCT_INFERIOR_ARGUMENTS (inferior_argc, inferior_argv);
 > 
 > Andrew> the above will also need to be tweeked to be:
 > Andrew> 	n = gdbarch_construct_inferior_arguments (current_gdbarch, ...);
 > 
 > Also done.
 > Thanks.
 > 
 > Andrew> Just check with Fernando and Elena.
 > 
 > Ok.

main.c changes are ok.

Elena


 > 
 > Tom