* [RFA] correct XMM register positions for win32.
@ 2001-11-30 6:51 Pierre Muller
2001-11-21 15:12 ` Pierre Muller
2001-11-30 9:03 ` Christopher Faylor
0 siblings, 2 replies; 5+ messages in thread
From: Pierre Muller @ 2001-11-30 6:51 UTC (permalink / raw)
To: gdb-patches
Thanks to Momchil Velikov,
Windows seems indeed to use FXSAVE
assemlber instruction to fill the ExtendedRegisters
array.
The same instruction with the same layout seems to be used
by the Pentium clones (at least for AMD).
Thus the offset changed below are now
tested and conform to the FXSAVE
instruction.
2001-11-30 Pierre Muller <muller@ics.u-strasbg.fr>
* win32-nat.c (mappings): Correct position of XMM registers,
based on FXSAVE instruction structure.
Index: win32-nat.c
===================================================================
RCS file: /cvs/src/src/gdb/win32-nat.c,v
retrieving revision 1.40
diff -r1.40 win32-nat.c
182,191c182,191
< context_offset (ExtendedRegisters[0*16]),
< context_offset (ExtendedRegisters[1*16]),
< context_offset (ExtendedRegisters[2*16]),
< context_offset (ExtendedRegisters[3*16]),
< context_offset (ExtendedRegisters[4*16]),
< context_offset (ExtendedRegisters[5*16]),
< context_offset (ExtendedRegisters[6*16]),
< context_offset (ExtendedRegisters[7*16]),
< /* MXCSR untested */
< context_offset (ExtendedRegisters[8*16])
---
> context_offset (ExtendedRegisters[10*16]),
> context_offset (ExtendedRegisters[11*16]),
> context_offset (ExtendedRegisters[12*16]),
> context_offset (ExtendedRegisters[13*16]),
> context_offset (ExtendedRegisters[14*16]),
> context_offset (ExtendedRegisters[15*16]),
> context_offset (ExtendedRegisters[16*16]),
> context_offset (ExtendedRegisters[17*16]),
> /* MXCSR */
> context_offset (ExtendedRegisters[24])
Pierre Muller
Institut Charles Sadron
6,rue Boussingault
F 67083 STRASBOURG CEDEX (France)
mailto:muller@ics.u-strasbg.fr
Phone : (33)-3-88-41-40-07 Fax : (33)-3-88-41-40-99
^ permalink raw reply [flat|nested] 5+ messages in thread
* [RFA] correct XMM register positions for win32.
2001-11-30 6:51 [RFA] correct XMM register positions for win32 Pierre Muller
@ 2001-11-21 15:12 ` Pierre Muller
2001-11-30 9:03 ` Christopher Faylor
1 sibling, 0 replies; 5+ messages in thread
From: Pierre Muller @ 2001-11-21 15:12 UTC (permalink / raw)
To: gdb-patches
Thanks to Momchil Velikov,
Windows seems indeed to use FXSAVE
assemlber instruction to fill the ExtendedRegisters
array.
The same instruction with the same layout seems to be used
by the Pentium clones (at least for AMD).
Thus the offset changed below are now
tested and conform to the FXSAVE
instruction.
2001-11-30 Pierre Muller <muller@ics.u-strasbg.fr>
* win32-nat.c (mappings): Correct position of XMM registers,
based on FXSAVE instruction structure.
Index: win32-nat.c
===================================================================
RCS file: /cvs/src/src/gdb/win32-nat.c,v
retrieving revision 1.40
diff -r1.40 win32-nat.c
182,191c182,191
< context_offset (ExtendedRegisters[0*16]),
< context_offset (ExtendedRegisters[1*16]),
< context_offset (ExtendedRegisters[2*16]),
< context_offset (ExtendedRegisters[3*16]),
< context_offset (ExtendedRegisters[4*16]),
< context_offset (ExtendedRegisters[5*16]),
< context_offset (ExtendedRegisters[6*16]),
< context_offset (ExtendedRegisters[7*16]),
< /* MXCSR untested */
< context_offset (ExtendedRegisters[8*16])
---
> context_offset (ExtendedRegisters[10*16]),
> context_offset (ExtendedRegisters[11*16]),
> context_offset (ExtendedRegisters[12*16]),
> context_offset (ExtendedRegisters[13*16]),
> context_offset (ExtendedRegisters[14*16]),
> context_offset (ExtendedRegisters[15*16]),
> context_offset (ExtendedRegisters[16*16]),
> context_offset (ExtendedRegisters[17*16]),
> /* MXCSR */
> context_offset (ExtendedRegisters[24])
Pierre Muller
Institut Charles Sadron
6,rue Boussingault
F 67083 STRASBOURG CEDEX (France)
mailto:muller@ics.u-strasbg.fr
Phone : (33)-3-88-41-40-07 Fax : (33)-3-88-41-40-99
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [RFA] correct XMM register positions for win32.
2001-11-30 6:51 [RFA] correct XMM register positions for win32 Pierre Muller
2001-11-21 15:12 ` Pierre Muller
@ 2001-11-30 9:03 ` Christopher Faylor
2001-11-21 23:07 ` Christopher Faylor
2001-12-03 0:21 ` Pierre Muller
1 sibling, 2 replies; 5+ messages in thread
From: Christopher Faylor @ 2001-11-30 9:03 UTC (permalink / raw)
To: gdb-patches
Please check this in, Pierre.
Also, please use 'diff -up' or 'diff -cp' for your future patches.
cgf
On Fri, Nov 30, 2001 at 03:50:14PM +0100, Pierre Muller wrote:
> Thanks to Momchil Velikov,
>Windows seems indeed to use FXSAVE
>assemlber instruction to fill the ExtendedRegisters
>array.
>
> The same instruction with the same layout seems to be used
>by the Pentium clones (at least for AMD).
>
>Thus the offset changed below are now
>tested and conform to the FXSAVE
>instruction.
>
>
>2001-11-30 Pierre Muller <muller@ics.u-strasbg.fr>
> * win32-nat.c (mappings): Correct position of XMM registers,
> based on FXSAVE instruction structure.
>
>Index: win32-nat.c
>===================================================================
>RCS file: /cvs/src/src/gdb/win32-nat.c,v
>retrieving revision 1.40
>diff -r1.40 win32-nat.c
>182,191c182,191
>< context_offset (ExtendedRegisters[0*16]),
>< context_offset (ExtendedRegisters[1*16]),
>< context_offset (ExtendedRegisters[2*16]),
>< context_offset (ExtendedRegisters[3*16]),
>< context_offset (ExtendedRegisters[4*16]),
>< context_offset (ExtendedRegisters[5*16]),
>< context_offset (ExtendedRegisters[6*16]),
>< context_offset (ExtendedRegisters[7*16]),
>< /* MXCSR untested */
>< context_offset (ExtendedRegisters[8*16])
>---
> > context_offset (ExtendedRegisters[10*16]),
> > context_offset (ExtendedRegisters[11*16]),
> > context_offset (ExtendedRegisters[12*16]),
> > context_offset (ExtendedRegisters[13*16]),
> > context_offset (ExtendedRegisters[14*16]),
> > context_offset (ExtendedRegisters[15*16]),
> > context_offset (ExtendedRegisters[16*16]),
> > context_offset (ExtendedRegisters[17*16]),
> > /* MXCSR */
> > context_offset (ExtendedRegisters[24])
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [RFA] correct XMM register positions for win32.
2001-11-30 9:03 ` Christopher Faylor
@ 2001-11-21 23:07 ` Christopher Faylor
2001-12-03 0:21 ` Pierre Muller
1 sibling, 0 replies; 5+ messages in thread
From: Christopher Faylor @ 2001-11-21 23:07 UTC (permalink / raw)
To: gdb-patches
Please check this in, Pierre.
Also, please use 'diff -up' or 'diff -cp' for your future patches.
cgf
On Fri, Nov 30, 2001 at 03:50:14PM +0100, Pierre Muller wrote:
> Thanks to Momchil Velikov,
>Windows seems indeed to use FXSAVE
>assemlber instruction to fill the ExtendedRegisters
>array.
>
> The same instruction with the same layout seems to be used
>by the Pentium clones (at least for AMD).
>
>Thus the offset changed below are now
>tested and conform to the FXSAVE
>instruction.
>
>
>2001-11-30 Pierre Muller <muller@ics.u-strasbg.fr>
> * win32-nat.c (mappings): Correct position of XMM registers,
> based on FXSAVE instruction structure.
>
>Index: win32-nat.c
>===================================================================
>RCS file: /cvs/src/src/gdb/win32-nat.c,v
>retrieving revision 1.40
>diff -r1.40 win32-nat.c
>182,191c182,191
>< context_offset (ExtendedRegisters[0*16]),
>< context_offset (ExtendedRegisters[1*16]),
>< context_offset (ExtendedRegisters[2*16]),
>< context_offset (ExtendedRegisters[3*16]),
>< context_offset (ExtendedRegisters[4*16]),
>< context_offset (ExtendedRegisters[5*16]),
>< context_offset (ExtendedRegisters[6*16]),
>< context_offset (ExtendedRegisters[7*16]),
>< /* MXCSR untested */
>< context_offset (ExtendedRegisters[8*16])
>---
> > context_offset (ExtendedRegisters[10*16]),
> > context_offset (ExtendedRegisters[11*16]),
> > context_offset (ExtendedRegisters[12*16]),
> > context_offset (ExtendedRegisters[13*16]),
> > context_offset (ExtendedRegisters[14*16]),
> > context_offset (ExtendedRegisters[15*16]),
> > context_offset (ExtendedRegisters[16*16]),
> > context_offset (ExtendedRegisters[17*16]),
> > /* MXCSR */
> > context_offset (ExtendedRegisters[24])
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [RFA] correct XMM register positions for win32.
2001-11-30 9:03 ` Christopher Faylor
2001-11-21 23:07 ` Christopher Faylor
@ 2001-12-03 0:21 ` Pierre Muller
1 sibling, 0 replies; 5+ messages in thread
From: Pierre Muller @ 2001-12-03 0:21 UTC (permalink / raw)
To: gdb-patches
At 18:03 30/11/2001 , Christopher Faylor a écrit:
>Please check this in, Pierre.
>
>Also, please use 'diff -up' or 'diff -cp' for your future patches.
Committed, thanks,
and sorry for wrong patch format...
I resend here a better formatted patch.
2001-11-30 Pierre Muller <muller@ics.u-strasbg.fr>
* win32-nat.c (mappings): Correct position of XMM registers,
based on FXSAVE instruction structure.
Index: win32-nat.c
===================================================================
RCS file: /cvs/src/src/gdb/win32-nat.c,v
retrieving revision 1.40
diff -u -p -r1.40 win32-nat.c
--- win32-nat.c 2001/11/27 05:16:39 1.40
+++ win32-nat.c 2001/12/03 08:13:36
@@ -179,16 +179,16 @@ static const int mappings[] =
context_offset (FloatSave.ErrorSelector)
#ifdef HAVE_SSE_REGS
/* XMM0-7 */ ,
- context_offset (ExtendedRegisters[0*16]),
- context_offset (ExtendedRegisters[1*16]),
- context_offset (ExtendedRegisters[2*16]),
- context_offset (ExtendedRegisters[3*16]),
- context_offset (ExtendedRegisters[4*16]),
- context_offset (ExtendedRegisters[5*16]),
- context_offset (ExtendedRegisters[6*16]),
- context_offset (ExtendedRegisters[7*16]),
- /* MXCSR untested */
- context_offset (ExtendedRegisters[8*16])
+ context_offset (ExtendedRegisters[10*16]),
+ context_offset (ExtendedRegisters[11*16]),
+ context_offset (ExtendedRegisters[12*16]),
+ context_offset (ExtendedRegisters[13*16]),
+ context_offset (ExtendedRegisters[14*16]),
+ context_offset (ExtendedRegisters[15*16]),
+ context_offset (ExtendedRegisters[16*16]),
+ context_offset (ExtendedRegisters[17*16]),
+ /* MXCSR */
+ context_offset (ExtendedRegisters[24])
#endif
};
Pierre Muller
Institut Charles Sadron
6,rue Boussingault
F 67083 STRASBOURG CEDEX (France)
mailto:muller@ics.u-strasbg.fr
Phone : (33)-3-88-41-40-07 Fax : (33)-3-88-41-40-99
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2001-12-03 8:21 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2001-11-30 6:51 [RFA] correct XMM register positions for win32 Pierre Muller
2001-11-21 15:12 ` Pierre Muller
2001-11-30 9:03 ` Christopher Faylor
2001-11-21 23:07 ` Christopher Faylor
2001-12-03 0:21 ` Pierre Muller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox