Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Christopher Faylor <cgf@redhat.com>
To: gdb-patches <gdb-patches@sources.redhat.com>
Subject: Re: [RFA] correct XMM register positions for win32.
Date: Fri, 30 Nov 2001 09:03:00 -0000	[thread overview]
Message-ID: <20011130170324.GA24463@redhat.com> (raw)
In-Reply-To: <4.2.0.58.20011130154628.00aca598@ics.u-strasbg.fr>

Please check this in, Pierre.

Also, please use 'diff -up' or 'diff -cp' for your future patches.

cgf

On Fri, Nov 30, 2001 at 03:50:14PM +0100, Pierre Muller wrote:
>   Thanks to Momchil Velikov,
>Windows seems indeed to use FXSAVE 
>assemlber instruction to fill the ExtendedRegisters
>array.
>
>   The same instruction with the same layout seems to be used
>by the Pentium clones (at least for AMD).  
>
>Thus the offset changed below are now 
>tested and conform to the FXSAVE
>instruction.
>
>
>2001-11-30 Pierre Muller  <muller@ics.u-strasbg.fr>
>	* win32-nat.c (mappings): Correct position of XMM registers,
>	based on FXSAVE instruction structure.
>
>Index: win32-nat.c
>===================================================================
>RCS file: /cvs/src/src/gdb/win32-nat.c,v
>retrieving revision 1.40
>diff -r1.40 win32-nat.c
>182,191c182,191
><   context_offset (ExtendedRegisters[0*16]),
><   context_offset (ExtendedRegisters[1*16]),
><   context_offset (ExtendedRegisters[2*16]),
><   context_offset (ExtendedRegisters[3*16]),
><   context_offset (ExtendedRegisters[4*16]),
><   context_offset (ExtendedRegisters[5*16]),
><   context_offset (ExtendedRegisters[6*16]),
><   context_offset (ExtendedRegisters[7*16]),
><   /* MXCSR untested */
><   context_offset (ExtendedRegisters[8*16])
>---
> >   context_offset (ExtendedRegisters[10*16]),
> >   context_offset (ExtendedRegisters[11*16]),
> >   context_offset (ExtendedRegisters[12*16]),
> >   context_offset (ExtendedRegisters[13*16]),
> >   context_offset (ExtendedRegisters[14*16]),
> >   context_offset (ExtendedRegisters[15*16]),
> >   context_offset (ExtendedRegisters[16*16]),
> >   context_offset (ExtendedRegisters[17*16]),
> >   /* MXCSR */
> >   context_offset (ExtendedRegisters[24])


WARNING: multiple messages have this Message-ID
From: Christopher Faylor <cgf@redhat.com>
To: gdb-patches <gdb-patches@sources.redhat.com>
Subject: Re: [RFA] correct XMM register positions for win32.
Date: Wed, 21 Nov 2001 23:07:00 -0000	[thread overview]
Message-ID: <20011130170324.GA24463@redhat.com> (raw)
Message-ID: <20011121230700.1u-aTYKX7KPoOkJyA5dfPvw6-NXmkDAzpVyCOmlR8Rg@z> (raw)
In-Reply-To: <4.2.0.58.20011130154628.00aca598@ics.u-strasbg.fr>

Please check this in, Pierre.

Also, please use 'diff -up' or 'diff -cp' for your future patches.

cgf

On Fri, Nov 30, 2001 at 03:50:14PM +0100, Pierre Muller wrote:
>   Thanks to Momchil Velikov,
>Windows seems indeed to use FXSAVE 
>assemlber instruction to fill the ExtendedRegisters
>array.
>
>   The same instruction with the same layout seems to be used
>by the Pentium clones (at least for AMD).  
>
>Thus the offset changed below are now 
>tested and conform to the FXSAVE
>instruction.
>
>
>2001-11-30 Pierre Muller  <muller@ics.u-strasbg.fr>
>	* win32-nat.c (mappings): Correct position of XMM registers,
>	based on FXSAVE instruction structure.
>
>Index: win32-nat.c
>===================================================================
>RCS file: /cvs/src/src/gdb/win32-nat.c,v
>retrieving revision 1.40
>diff -r1.40 win32-nat.c
>182,191c182,191
><   context_offset (ExtendedRegisters[0*16]),
><   context_offset (ExtendedRegisters[1*16]),
><   context_offset (ExtendedRegisters[2*16]),
><   context_offset (ExtendedRegisters[3*16]),
><   context_offset (ExtendedRegisters[4*16]),
><   context_offset (ExtendedRegisters[5*16]),
><   context_offset (ExtendedRegisters[6*16]),
><   context_offset (ExtendedRegisters[7*16]),
><   /* MXCSR untested */
><   context_offset (ExtendedRegisters[8*16])
>---
> >   context_offset (ExtendedRegisters[10*16]),
> >   context_offset (ExtendedRegisters[11*16]),
> >   context_offset (ExtendedRegisters[12*16]),
> >   context_offset (ExtendedRegisters[13*16]),
> >   context_offset (ExtendedRegisters[14*16]),
> >   context_offset (ExtendedRegisters[15*16]),
> >   context_offset (ExtendedRegisters[16*16]),
> >   context_offset (ExtendedRegisters[17*16]),
> >   /* MXCSR */
> >   context_offset (ExtendedRegisters[24])


  parent reply	other threads:[~2001-11-30  9:03 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2001-11-30  6:51 Pierre Muller
2001-11-21 15:12 ` Pierre Muller
2001-11-30  9:03 ` Christopher Faylor [this message]
2001-11-21 23:07   ` Christopher Faylor
2001-12-03  0:21   ` Pierre Muller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20011130170324.GA24463@redhat.com \
    --to=cgf@redhat.com \
    --cc=gdb-patches@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox