From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-10908-listarch-gdb-patches=sourceware.cygnus.com@sources.redhat.com>
Received: (qmail 17083 invoked by alias); 30 Nov 2001 17:03:23 -0000
Mailing-List: contact gdb-patches-help@sourceware.cygnus.com; run by ezmlm
Precedence: bulk
List-Subscribe: <mailto:gdb-patches-subscribe@sources.redhat.com>
List-Archive: <http://sources.redhat.com/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sources.redhat.com>
List-Help: <mailto:gdb-patches-help@sources.redhat.com>, <http://sources.redhat.com/ml/#faqs>
Sender: gdb-patches-owner@sources.redhat.com
Received: (qmail 17061 invoked from network); 30 Nov 2001 17:03:22 -0000
Received: from unknown (HELO lacrosse.corp.redhat.com) (207.175.42.154)
  by hostedprojects.ges.redhat.com with SMTP; 30 Nov 2001 17:03:22 -0000
Received: from trixie.bosbc.com (cgf.cipe.redhat.com [10.0.1.172])
	by lacrosse.corp.redhat.com (8.11.6/8.9.3) with ESMTP id fAUH3Lh26949
	for <gdb-patches@sources.redhat.com>; Fri, 30 Nov 2001 12:03:21 -0500
Received: (from cgf@localhost)
	by trixie.bosbc.com (8.11.6/8.8.7) id fAUH3Of24520
	for gdb-patches@sources.redhat.com; Fri, 30 Nov 2001 12:03:24 -0500
Date: Wed, 21 Nov 2001 23:07:00 -0000
From: Christopher Faylor <cgf@redhat.com>
To: gdb-patches <gdb-patches@sources.redhat.com>
Subject: Re: [RFA] correct XMM register positions for win32.
Message-ID: <20011130170324.GA24463@redhat.com>
Mail-Followup-To: gdb-patches <gdb-patches@sources.redhat.com>
References: <4.2.0.58.20011130154628.00aca598@ics.u-strasbg.fr>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <4.2.0.58.20011130154628.00aca598@ics.u-strasbg.fr>
User-Agent: Mutt/1.3.23.1i
X-SW-Source: 2001-11/txt/msg00404.txt.bz2
Message-ID: <20011121230700.1u-aTYKX7KPoOkJyA5dfPvw6-NXmkDAzpVyCOmlR8Rg@z>

Please check this in, Pierre.

Also, please use 'diff -up' or 'diff -cp' for your future patches.

cgf

On Fri, Nov 30, 2001 at 03:50:14PM +0100, Pierre Muller wrote:
>   Thanks to Momchil Velikov,
>Windows seems indeed to use FXSAVE 
>assemlber instruction to fill the ExtendedRegisters
>array.
>
>   The same instruction with the same layout seems to be used
>by the Pentium clones (at least for AMD).  
>
>Thus the offset changed below are now 
>tested and conform to the FXSAVE
>instruction.
>
>
>2001-11-30 Pierre Muller  <muller@ics.u-strasbg.fr>
>	* win32-nat.c (mappings): Correct position of XMM registers,
>	based on FXSAVE instruction structure.
>
>Index: win32-nat.c
>===================================================================
>RCS file: /cvs/src/src/gdb/win32-nat.c,v
>retrieving revision 1.40
>diff -r1.40 win32-nat.c
>182,191c182,191
><   context_offset (ExtendedRegisters[0*16]),
><   context_offset (ExtendedRegisters[1*16]),
><   context_offset (ExtendedRegisters[2*16]),
><   context_offset (ExtendedRegisters[3*16]),
><   context_offset (ExtendedRegisters[4*16]),
><   context_offset (ExtendedRegisters[5*16]),
><   context_offset (ExtendedRegisters[6*16]),
><   context_offset (ExtendedRegisters[7*16]),
><   /* MXCSR untested */
><   context_offset (ExtendedRegisters[8*16])
>---
> >   context_offset (ExtendedRegisters[10*16]),
> >   context_offset (ExtendedRegisters[11*16]),
> >   context_offset (ExtendedRegisters[12*16]),
> >   context_offset (ExtendedRegisters[13*16]),
> >   context_offset (ExtendedRegisters[14*16]),
> >   context_offset (ExtendedRegisters[15*16]),
> >   context_offset (ExtendedRegisters[16*16]),
> >   context_offset (ExtendedRegisters[17*16]),
> >   /* MXCSR */
> >   context_offset (ExtendedRegisters[24])