From: Nick Roberts <nickrob@snap.net.nz>
To: Tom Tromey <tromey@redhat.com>
Cc: gdb-patches@sources.redhat.com
Subject: Re: RFA: Patch: annotations -vs- deprecated hooks
Date: Mon, 14 Jul 2008 01:37:00 -0000 [thread overview]
Message-ID: <18554.44449.266149.362665@kahikatea.snap.net.nz> (raw)
In-Reply-To: <m3k5fp9tnc.fsf@fleche.redhat.com>
> When browsing gdb, I find it very strange to see how many things are
> marked deprecated, and for how long. E.g.,
> deprecated_annotate_starting_hook is not set anywhere in gdb, but has
> been deprecated since 2004. That seems like an inordinately long
> deprecation for something which is unused.
In Emacs, variables get marked as obsolete but they are rarely removed from the
code. I think that RMS' view is that marking them as obsolete simply
discourages _further_ use of them and that legacy software requires that they
stay.
> Nick> This patch, however, while probably safe (I've not checked)
> Nick> doesn't seem worthwhile to me since this code _will_ disappear
> Nick> in the future anyway.
>
> Do you know when this will be? If it is soon, then I don't mind
> holding off. If it will be a year, or years, then I think it would be
> strange to reject a cleanup in favor of some distant, unwritten patch.
I could tell you when Emacs no longer needs them, but even then I guess
people will still be using old copies, and then there may be other
projects. So it probably is a long way off.
Creating observers just for breakpoints results in a mixed approach for
annotations as others don't use observers and removing the deprecated label
might encourage their use. Also, in the past, I have submitted a patch for
similar observers for use with MI which could confuse.
http://sourceware.org/ml/gdb-patches/2008-06/msg00000.html
http://sourceware.org/ml/gdb-patches/2008-06/msg00012.html
http://sourceware.org/ml/gdb-patches/2008-06/msg00018.html
I would rather these were incorporated first since MI is the future.
I don't feel that strongly about it though and if the changes are approved
well before a release I can test them against Emacs. Certainly (all) the
the deprecated_annotate_*_hooks could go.
--
Nick http://www.inet.net.nz/~nickrob
next prev parent reply other threads:[~2008-07-14 1:37 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-13 21:59 Tom Tromey
2008-07-13 22:26 ` Nick Roberts
2008-07-13 23:15 ` Tom Tromey
2008-07-14 0:20 ` Nick Roberts
2008-07-14 0:50 ` Tom Tromey
2008-07-14 0:57 ` Daniel Jacobowitz
2008-07-14 1:37 ` Nick Roberts [this message]
2008-07-14 15:22 ` Tom Tromey
2008-07-14 5:00 ` Joel Brobecker
2008-07-14 17:27 ` Joel Brobecker
2008-07-14 17:46 ` Tom Tromey
2008-07-16 12:42 ` Nick Roberts
2008-07-28 17:50 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=18554.44449.266149.362665@kahikatea.snap.net.nz \
--to=nickrob@snap.net.nz \
--cc=gdb-patches@sources.redhat.com \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox