From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 890 invoked by alias); 14 Jul 2008 01:37:25 -0000 Received: (qmail 882 invoked by uid 22791); 14 Jul 2008 01:37:24 -0000 X-Spam-Check-By: sourceware.org Received: from viper.snap.net.nz (HELO viper.snap.net.nz) (202.37.101.25) by sourceware.org (qpsmtpd/0.31) with ESMTP; Mon, 14 Jul 2008 01:36:57 +0000 Received: from kahikatea.snap.net.nz (89.30.255.123.static.snap.net.nz [123.255.30.89]) by viper.snap.net.nz (Postfix) with ESMTP id 773253DA665; Mon, 14 Jul 2008 13:36:53 +1200 (NZST) Received: by kahikatea.snap.net.nz (Postfix, from userid 1000) id B89078FC6D; Mon, 14 Jul 2008 13:36:34 +1200 (NZST) From: Nick Roberts MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <18554.44449.266149.362665@kahikatea.snap.net.nz> Date: Mon, 14 Jul 2008 01:37:00 -0000 To: Tom Tromey Cc: gdb-patches@sources.redhat.com Subject: Re: RFA: Patch: annotations -vs- deprecated hooks In-Reply-To: References: <18554.32994.171402.593716@kahikatea.snap.net.nz> <18554.39826.254742.402462@kahikatea.snap.net.nz> X-Mailer: VM 7.19 under Emacs 22.2.50.3 X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-07/txt/msg00275.txt.bz2 > When browsing gdb, I find it very strange to see how many things are > marked deprecated, and for how long. E.g., > deprecated_annotate_starting_hook is not set anywhere in gdb, but has > been deprecated since 2004. That seems like an inordinately long > deprecation for something which is unused. In Emacs, variables get marked as obsolete but they are rarely removed from the code. I think that RMS' view is that marking them as obsolete simply discourages _further_ use of them and that legacy software requires that they stay. > Nick> This patch, however, while probably safe (I've not checked) > Nick> doesn't seem worthwhile to me since this code _will_ disappear > Nick> in the future anyway. > > Do you know when this will be? If it is soon, then I don't mind > holding off. If it will be a year, or years, then I think it would be > strange to reject a cleanup in favor of some distant, unwritten patch. I could tell you when Emacs no longer needs them, but even then I guess people will still be using old copies, and then there may be other projects. So it probably is a long way off. Creating observers just for breakpoints results in a mixed approach for annotations as others don't use observers and removing the deprecated label might encourage their use. Also, in the past, I have submitted a patch for similar observers for use with MI which could confuse. http://sourceware.org/ml/gdb-patches/2008-06/msg00000.html http://sourceware.org/ml/gdb-patches/2008-06/msg00012.html http://sourceware.org/ml/gdb-patches/2008-06/msg00018.html I would rather these were incorporated first since MI is the future. I don't feel that strongly about it though and if the changes are approved well before a release I can test them against Emacs. Certainly (all) the the deprecated_annotate_*_hooks could go. -- Nick http://www.inet.net.nz/~nickrob