Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Nick Roberts <nickrob@snap.net.nz>
To: Tom Tromey <tromey@redhat.com>
Cc: gdb-patches@sources.redhat.com
Subject: Re: RFA: Patch: annotations -vs- deprecated hooks
Date: Mon, 14 Jul 2008 00:20:00 -0000	[thread overview]
Message-ID: <18554.39826.254742.402462@kahikatea.snap.net.nz> (raw)
In-Reply-To: <m3y7459y06.fsf@fleche.redhat.com>

Tom Tromey writes:
 > >>>>> "Nick" == Nick Roberts <nickrob@snap.net.nz> writes:
 > 
 > Nick> The plan is to remove annotations wnen GDB/MI has full
 > Nick> functionality anyway.  Is there much benefit from doing this?
 > Nick> If not, I would suggest that "if it ain't broke don't fix it".
 > 
 > After being confused by the event/hook/observer stuff while working on
 > Python, I decided that I'd try to get rid of the deprecated event
 > mechanisms.  It never occurred to me that gdb maintainers might not
 > want this, so I didn't ask about it first.

I'm not a maintainer, but maybe that's not what you meant.

 > Is it just annotations that you care about, or all the deprecated hook
 > stuff?  I think it all falls into the category of not-broken.

Emacs still uses annotations and it seems to work OK.  Your earlier change,
emoving event hooks, removes a significant amount of code and stops others from
using them in the future.  This patch, however, while probably safe (I've not
checked) doesn't seem worthwhile to me since this code _will_ disappear in the
future anyway.

-- 
Nick                                           http://www.inet.net.nz/~nickrob


  reply	other threads:[~2008-07-14  0:20 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-07-13 21:59 Tom Tromey
2008-07-13 22:26 ` Nick Roberts
2008-07-13 23:15   ` Tom Tromey
2008-07-14  0:20     ` Nick Roberts [this message]
2008-07-14  0:50       ` Tom Tromey
2008-07-14  0:57         ` Daniel Jacobowitz
2008-07-14  1:37         ` Nick Roberts
2008-07-14 15:22           ` Tom Tromey
2008-07-14  5:00 ` Joel Brobecker
2008-07-14 17:27 ` Joel Brobecker
2008-07-14 17:46   ` Tom Tromey
2008-07-16 12:42   ` Nick Roberts
2008-07-28 17:50   ` Tom Tromey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=18554.39826.254742.402462@kahikatea.snap.net.nz \
    --to=nickrob@snap.net.nz \
    --cc=gdb-patches@sources.redhat.com \
    --cc=tromey@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox