From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20861 invoked by alias); 14 Jul 2008 00:20:19 -0000 Received: (qmail 20808 invoked by uid 22791); 14 Jul 2008 00:20:18 -0000 X-Spam-Check-By: sourceware.org Received: from viper.snap.net.nz (HELO viper.snap.net.nz) (202.37.101.25) by sourceware.org (qpsmtpd/0.31) with ESMTP; Mon, 14 Jul 2008 00:19:52 +0000 Received: from kahikatea.snap.net.nz (151.31.255.123.static.snap.net.nz [123.255.31.151]) by viper.snap.net.nz (Postfix) with ESMTP id 1EAF43DB9BC; Mon, 14 Jul 2008 12:19:49 +1200 (NZST) Received: by kahikatea.snap.net.nz (Postfix, from userid 1000) id 4423E8FC6D; Mon, 14 Jul 2008 12:19:30 +1200 (NZST) From: Nick Roberts MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <18554.39826.254742.402462@kahikatea.snap.net.nz> Date: Mon, 14 Jul 2008 00:20:00 -0000 To: Tom Tromey Cc: gdb-patches@sources.redhat.com Subject: Re: RFA: Patch: annotations -vs- deprecated hooks In-Reply-To: References: <18554.32994.171402.593716@kahikatea.snap.net.nz> X-Mailer: VM 7.19 under Emacs 22.2.50.3 X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-07/txt/msg00272.txt.bz2 Tom Tromey writes: > >>>>> "Nick" == Nick Roberts writes: > > Nick> The plan is to remove annotations wnen GDB/MI has full > Nick> functionality anyway. Is there much benefit from doing this? > Nick> If not, I would suggest that "if it ain't broke don't fix it". > > After being confused by the event/hook/observer stuff while working on > Python, I decided that I'd try to get rid of the deprecated event > mechanisms. It never occurred to me that gdb maintainers might not > want this, so I didn't ask about it first. I'm not a maintainer, but maybe that's not what you meant. > Is it just annotations that you care about, or all the deprecated hook > stuff? I think it all falls into the category of not-broken. Emacs still uses annotations and it seems to work OK. Your earlier change, emoving event hooks, removes a significant amount of code and stops others from using them in the future. This patch, however, while probably safe (I've not checked) doesn't seem worthwhile to me since this code _will_ disappear in the future anyway. -- Nick http://www.inet.net.nz/~nickrob