From: Nick Roberts <nickrob@snap.net.nz>
To: tromey@redhat.com
Cc: gdb-patches@sources.redhat.com
Subject: Re: RFA: Patch: annotations -vs- deprecated hooks
Date: Sun, 13 Jul 2008 22:26:00 -0000 [thread overview]
Message-ID: <18554.32994.171402.593716@kahikatea.snap.net.nz> (raw)
In-Reply-To: <m363r9bg3q.fsf@fleche.redhat.com>
> This patch removes a few deprecated hooks associated with annotations.
>
> This requires my previous observer patch.
>
> Some of these are only used by annotations; I changed the annotation
> code to use observers instead. Some of these hooks are called by
> annotations but never set. These I just deleted.
>
> There are still a couple of hooks called by the annotations code that
> are used by gdbtk. This setup seems weird to me. I guess these ought
> to be replaced by observers.
>
> Built and regression tested on x86 F8. Ok?
The plan is to remove annotations wnen GDB/MI has full functionality anyway.
Is there much benefit from doing this? If not, I would suggest that "if it
ain't broke don't fix it".
--
Nick http://www.inet.net.nz/~nickrob
next prev parent reply other threads:[~2008-07-13 22:26 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-13 21:59 Tom Tromey
2008-07-13 22:26 ` Nick Roberts [this message]
2008-07-13 23:15 ` Tom Tromey
2008-07-14 0:20 ` Nick Roberts
2008-07-14 0:50 ` Tom Tromey
2008-07-14 0:57 ` Daniel Jacobowitz
2008-07-14 1:37 ` Nick Roberts
2008-07-14 15:22 ` Tom Tromey
2008-07-14 5:00 ` Joel Brobecker
2008-07-14 17:27 ` Joel Brobecker
2008-07-14 17:46 ` Tom Tromey
2008-07-16 12:42 ` Nick Roberts
2008-07-28 17:50 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=18554.32994.171402.593716@kahikatea.snap.net.nz \
--to=nickrob@snap.net.nz \
--cc=gdb-patches@sources.redhat.com \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox