From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 32054 invoked by alias); 13 Jul 2008 22:26:29 -0000 Received: (qmail 32044 invoked by uid 22791); 13 Jul 2008 22:26:29 -0000 X-Spam-Check-By: sourceware.org Received: from viper.snap.net.nz (HELO viper.snap.net.nz) (202.37.101.25) by sourceware.org (qpsmtpd/0.31) with ESMTP; Sun, 13 Jul 2008 22:25:59 +0000 Received: from kahikatea.snap.net.nz (151.31.255.123.static.snap.net.nz [123.255.31.151]) by viper.snap.net.nz (Postfix) with ESMTP id 03F3C3DB469; Mon, 14 Jul 2008 10:25:56 +1200 (NZST) Received: by kahikatea.snap.net.nz (Postfix, from userid 1000) id CD9458FC6D; Mon, 14 Jul 2008 10:25:38 +1200 (NZST) From: Nick Roberts MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <18554.32994.171402.593716@kahikatea.snap.net.nz> Date: Sun, 13 Jul 2008 22:26:00 -0000 To: tromey@redhat.com Cc: gdb-patches@sources.redhat.com Subject: Re: RFA: Patch: annotations -vs- deprecated hooks In-Reply-To: References: X-Mailer: VM 7.19 under Emacs 22.2.50.3 X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-07/txt/msg00269.txt.bz2 > This patch removes a few deprecated hooks associated with annotations. > > This requires my previous observer patch. > > Some of these are only used by annotations; I changed the annotation > code to use observers instead. Some of these hooks are called by > annotations but never set. These I just deleted. > > There are still a couple of hooks called by the annotations code that > are used by gdbtk. This setup seems weird to me. I guess these ought > to be replaced by observers. > > Built and regression tested on x86 F8. Ok? The plan is to remove annotations wnen GDB/MI has full functionality anyway. Is there much benefit from doing this? If not, I would suggest that "if it ain't broke don't fix it". -- Nick http://www.inet.net.nz/~nickrob