Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Nick Roberts <nickrob@snap.net.nz>
To: Vladimir Prus <vladimir@codesourcery.com>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [RFA] Async mode fixes.
Date: Mon, 10 Mar 2008 09:12:00 -0000	[thread overview]
Message-ID: <18388.64350.993440.984898@kahikatea.snap.net.nz> (raw)
In-Reply-To: <200803101057.51401.vladimir@codesourcery.com>

 > Likewise, I think it's better to always use async mode,
 > if the target supports it. We're not at the point when we can do
 > it -- even with my patch, 'target async' has a couple of extra
 > failures relatively to 'target remote', and I never tried getting
 > test results for linux native -- but I think having async mode
 > always on should be end goal.

The patch isn't perfect, e.g., you say:

  I get the following with my patch:

	(gdb)
	-interpreter-exec console continue
	~"Continuing.\n"
	^running
	*stopped,reason="breakpoint-hit",bkptno="1",thread-id="1",.....

but that should be:

	(gdb)
	-interpreter-exec console continue
	~"Continuing.\n"
	^running
	(gdb)
	*stopped,reason="breakpoint-hit",bkptno="1",thread-id="1",.....

because in mi_execute_command, args.action == EXECUTE_COMMAND_SUPRESS_PROMPT
when it should be EXECUTE_COMMAND_DISPLAY_PROMPT.  This in turn is because
sync_execution is 1 when it should be 0.  Note that in Apple's code
sync_execution doesn't get toggled by async_enable/disable_stdin,

but, if Daniel is prepared to approve it, I would suggest committing it on
the trunk as there is plenty of time to polish it and it breaks things into
manageable chunks.

Then, at some stage, I could repost my patch as a much smaller diff and with
further improvements.

-- 
Nick                                           http://www.inet.net.nz/~nickrob


  reply	other threads:[~2008-03-10  9:12 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-03-05  7:27 Vladimir Prus
2008-03-07 22:19 ` Nick Roberts
2008-03-07 22:33   ` Daniel Jacobowitz
2008-03-08  8:16     ` Vladimir Prus
2008-03-08  8:59   ` Vladimir Prus
2008-03-08 20:36     ` Nick Roberts
2008-03-08 20:54       ` Daniel Jacobowitz
2008-03-08 23:09         ` Nick Roberts
2008-03-09  0:01           ` Daniel Jacobowitz
2008-03-10  7:58       ` Vladimir Prus
2008-03-10  9:12         ` Nick Roberts [this message]
2008-03-10 10:02           ` Vladimir Prus
2008-03-10 22:06             ` Nick Roberts
2008-03-14 18:26 ` Daniel Jacobowitz
2008-03-14 18:58   ` Vladimir Prus
2008-03-17 14:11 ` [commit] Fix compile error (Re: [RFA] Async mode fixes.) Ulrich Weigand
2008-03-17 14:17   ` Daniel Jacobowitz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=18388.64350.993440.984898@kahikatea.snap.net.nz \
    --to=nickrob@snap.net.nz \
    --cc=gdb-patches@sources.redhat.com \
    --cc=vladimir@codesourcery.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox