Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Daniel Jacobowitz <drow@false.org>
To: Nick Roberts <nickrob@snap.net.nz>
Cc: Vladimir Prus <vladimir@codesourcery.com>,
		gdb-patches@sources.redhat.com
Subject: Re: [RFA] Async mode fixes.
Date: Sun, 09 Mar 2008 00:01:00 -0000	[thread overview]
Message-ID: <20080309000037.GA3935@caradoc.them.org> (raw)
In-Reply-To: <18387.7279.827881.339251@kahikatea.snap.net.nz>

On Sun, Mar 09, 2008 at 12:08:31PM +1300, Nick Roberts wrote:
>  > > My changes aren't just for Linux, but an exec target.  I mean native
>  > > debugging (I think) with just one implementation - linux.  It sounds like
>  > > I'm inflating what I've done but other native targets can presumably be
>  > > adapted to make use of the changes in inf-ptrace.c, exec.c etc.
>  > 
>  > I think you mean "child" target?  target exec just reads an exec file
>  > on disk.
> 
> Well, my changes are in exec.c to exec_ops methods, not to target methods in
> inf-child.c.  Then ISTR these get inherited by target methods in inf-ptrace.c
> 
> Are you saying that these changes should really be in inf-child.c or just that
> I've misunderstood the concept of an exec target?

An exec target is the bit that owns the executable file.  Then other
targets live on top of it (on the "target stack") - target remote,
target sim, target child (which is just "run").  Putting things in the
exec target and not overriding them in any other target means that
they will work whenever there is an executable file, regardless of
target, and not work if we are attached without an executable file.

So if they go in exec.c, perhaps they shouldn't be in the target
vector at all.  Or perhaps they should be the default versions in
target.c if no target overrides them (like
default_region_ok_for_hw_watchpoint).

-- 
Daniel Jacobowitz
CodeSourcery


  reply	other threads:[~2008-03-09  0:01 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-03-05  7:27 Vladimir Prus
2008-03-07 22:19 ` Nick Roberts
2008-03-07 22:33   ` Daniel Jacobowitz
2008-03-08  8:16     ` Vladimir Prus
2008-03-08  8:59   ` Vladimir Prus
2008-03-08 20:36     ` Nick Roberts
2008-03-08 20:54       ` Daniel Jacobowitz
2008-03-08 23:09         ` Nick Roberts
2008-03-09  0:01           ` Daniel Jacobowitz [this message]
2008-03-10  7:58       ` Vladimir Prus
2008-03-10  9:12         ` Nick Roberts
2008-03-10 10:02           ` Vladimir Prus
2008-03-10 22:06             ` Nick Roberts
2008-03-14 18:26 ` Daniel Jacobowitz
2008-03-14 18:58   ` Vladimir Prus
2008-03-17 14:11 ` [commit] Fix compile error (Re: [RFA] Async mode fixes.) Ulrich Weigand
2008-03-17 14:17   ` Daniel Jacobowitz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080309000037.GA3935@caradoc.them.org \
    --to=drow@false.org \
    --cc=gdb-patches@sources.redhat.com \
    --cc=nickrob@snap.net.nz \
    --cc=vladimir@codesourcery.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox