Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Daniel Jacobowitz <drow@false.org>
To: Ulrich Weigand <uweigand@de.ibm.com>
Cc: Vladimir Prus <vladimir@codesourcery.com>,
		gdb-patches@sources.redhat.com
Subject: Re: [commit] Fix compile error (Re: [RFA] Async mode fixes.)
Date: Mon, 17 Mar 2008 14:17:00 -0000	[thread overview]
Message-ID: <20080317141707.GA20405@caradoc.them.org> (raw)
In-Reply-To: <200803171410.m2HEAWtC008777@d12av02.megacenter.de.ibm.com>

On Mon, Mar 17, 2008 at 03:10:32PM +0100, Ulrich Weigand wrote:
> > +  long time_at_cmd_start;
> [snip]
> > +  if (target_can_async_p ())
> > +    {
> > +      time_at_cmd_start = get_run_time ();
> [snip]
> > +  if (target_can_async_p () && target_executing)
> > +    {

> and the compiler error seems somewhat justified as the compiler cannot
> know that target_can_async_p () always returns the same value ...
> 
> Fixed by adding a dummy initializer, as already done for space_at_cmd_start.

Thanks, I was just looking at this.  But it made me wonder: what if
target_can_async_p changes when we execute the command?  For instance,
a "target" command?

Also, it looks like an async command which starts the target will
print out the time it took twice.

-- 
Daniel Jacobowitz
CodeSourcery


      reply	other threads:[~2008-03-17 14:17 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-03-05  7:27 [RFA] Async mode fixes Vladimir Prus
2008-03-07 22:19 ` Nick Roberts
2008-03-07 22:33   ` Daniel Jacobowitz
2008-03-08  8:16     ` Vladimir Prus
2008-03-08  8:59   ` Vladimir Prus
2008-03-08 20:36     ` Nick Roberts
2008-03-08 20:54       ` Daniel Jacobowitz
2008-03-08 23:09         ` Nick Roberts
2008-03-09  0:01           ` Daniel Jacobowitz
2008-03-10  7:58       ` Vladimir Prus
2008-03-10  9:12         ` Nick Roberts
2008-03-10 10:02           ` Vladimir Prus
2008-03-10 22:06             ` Nick Roberts
2008-03-14 18:26 ` Daniel Jacobowitz
2008-03-14 18:58   ` Vladimir Prus
2008-03-17 14:11 ` [commit] Fix compile error (Re: [RFA] Async mode fixes.) Ulrich Weigand
2008-03-17 14:17   ` Daniel Jacobowitz [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080317141707.GA20405@caradoc.them.org \
    --to=drow@false.org \
    --cc=gdb-patches@sources.redhat.com \
    --cc=uweigand@de.ibm.com \
    --cc=vladimir@codesourcery.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox