From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 14790 invoked by alias); 10 Mar 2008 09:12:53 -0000 Received: (qmail 14780 invoked by uid 22791); 10 Mar 2008 09:12:52 -0000 X-Spam-Check-By: sourceware.org Received: from viper.snap.net.nz (HELO viper.snap.net.nz) (202.37.101.8) by sourceware.org (qpsmtpd/0.31) with ESMTP; Mon, 10 Mar 2008 09:12:25 +0000 Received: from kahikatea.snap.net.nz (109.60.255.123.dynamic.snap.net.nz [123.255.60.109]) by viper.snap.net.nz (Postfix) with ESMTP id 490623D97D5; Mon, 10 Mar 2008 22:12:17 +1300 (NZDT) Received: by kahikatea.snap.net.nz (Postfix, from userid 1000) id CC52E8FC6D; Mon, 10 Mar 2008 22:12:00 +1300 (NZDT) From: Nick Roberts MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <18388.64350.993440.984898@kahikatea.snap.net.nz> Date: Mon, 10 Mar 2008 09:12:00 -0000 To: Vladimir Prus Cc: gdb-patches@sources.redhat.com Subject: Re: [RFA] Async mode fixes. In-Reply-To: <200803101057.51401.vladimir@codesourcery.com> References: <200803051027.29575.vladimir@codesourcery.com> <200803081158.40723.vladimir@codesourcery.com> <18386.63679.965070.279756@kahikatea.snap.net.nz> <200803101057.51401.vladimir@codesourcery.com> X-Mailer: VM 7.19 under Emacs 23.0.60.34 X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-03/txt/msg00087.txt.bz2 > Likewise, I think it's better to always use async mode, > if the target supports it. We're not at the point when we can do > it -- even with my patch, 'target async' has a couple of extra > failures relatively to 'target remote', and I never tried getting > test results for linux native -- but I think having async mode > always on should be end goal. The patch isn't perfect, e.g., you say: I get the following with my patch: (gdb) -interpreter-exec console continue ~"Continuing.\n" ^running *stopped,reason="breakpoint-hit",bkptno="1",thread-id="1",..... but that should be: (gdb) -interpreter-exec console continue ~"Continuing.\n" ^running (gdb) *stopped,reason="breakpoint-hit",bkptno="1",thread-id="1",..... because in mi_execute_command, args.action == EXECUTE_COMMAND_SUPRESS_PROMPT when it should be EXECUTE_COMMAND_DISPLAY_PROMPT. This in turn is because sync_execution is 1 when it should be 0. Note that in Apple's code sync_execution doesn't get toggled by async_enable/disable_stdin, but, if Daniel is prepared to approve it, I would suggest committing it on the trunk as there is plenty of time to polish it and it breaks things into manageable chunks. Then, at some stage, I could repost my patch as a much smaller diff and with further improvements. -- Nick http://www.inet.net.nz/~nickrob