[RFA] Set pascal language for DWarf debug information

[RFA] Set pascal language for DWarf debug information

[Pierre Muller]

  Following the patch was proposed by
Jonas Maebe in bugs database reference 2223


http://sourceware.org/cgi-bin/gnatsweb.pl?cmd=view%20audit-trail&database=gdb&pr=2223
?

 I extended his proposed patch to dwarfread.c file also.

 I can see no risks associated with the given patch,
and I hope that, despite the long time since my last
RFA, it is formatted correctly.
 It is in a way, pascal specific, but as it is
not in a pascal only file, I prefer to get approval
before committing.


Pierre Muller
maintainer of pascal language support.


2007-02-05  Pierre Muller  <muller@ics.u-strasbg.fr>

        * gdb/dwarfread.c (set_cu_language): Recognize LANG_PASCAL83 as
pascal language marker.
        * gdb/dwarf2read.c (set_cu_language): Recognize DW_LANG_Pascal83
as pascal language marker.


Index: gdb/dwarf2read.c
=================================================================== RCS
file: /cvs/src/src/gdb/dwarf2read.c,v
retrieving revision 1.214
diff -u -p -r1.214 dwarf2read.c
--- gdb/dwarf2read.c    28 Jan 2007 14:42:12 -0000      1.214
+++ gdb/dwarf2read.c    5 Feb 2007 15:26:58 -0000
@@ -6325,9 +6325,11 @@ set_cu_language (unsigned int lang, stru
     case DW_LANG_Modula2:
       cu->language = language_m2;
       break;
+    case DW_LANG_Pascal83:
+      cu->language = language_pascal;
+      break;
     case DW_LANG_Cobol74:
     case DW_LANG_Cobol85:
-    case DW_LANG_Pascal83:
     default:
       cu->language = language_minimal;
       break;
Index: gdb/dwarfread.c
=================================================================== RCS
file: /cvs/src/src/gdb/dwarfread.c,v
retrieving revision 1.46
diff -u -p -r1.46 dwarfread.c
--- gdb/dwarfread.c     9 Jan 2007 17:58:50 -0000       1.46
+++ gdb/dwarfread.c     5 Feb 2007 15:26:59 -0000
@@ -616,10 +616,12 @@ set_cu_language (struct dieinfo *dip)
     case LANG_FORTRAN90:
       cu_language = language_fortran;
       break;
+    case LANG_PASCAL83:
+      cu_language = language_pascal;
+      break;
     case LANG_ADA83:
     case LANG_COBOL74:
     case LANG_COBOL85:
-    case LANG_PASCAL83:
       /* We don't know anything special about these yet. */
       cu_language = language_unknown;
       break;

Re: [RFA] Set pascal language for DWarf debug information

[Daniel Jacobowitz]

On Mon, Feb 05, 2007 at 05:13:01PM +0100, Pierre Muller wrote:
>  I extended his proposed patch to dwarfread.c file also.

Might as well - but we will be deleting that file very shortly.

>  I can see no risks associated with the given patch,
> and I hope that, despite the long time since my last
> RFA, it is formatted correctly.
>  It is in a way, pascal specific, but as it is
> not in a pascal only file, I prefer to get approval
> before committing.

Thanks.  The patch is OK, with an adjusted ChangeLog entry:

> 2007-02-05  Pierre Muller  <muller@ics.u-strasbg.fr>
> 
>         * gdb/dwarfread.c (set_cu_language): Recognize LANG_PASCAL83 as
> pascal language marker.
>         * gdb/dwarf2read.c (set_cu_language): Recognize DW_LANG_Pascal83
> as pascal language marker.

	* dwarfread.c (set_cu_language): Recognize DW_LANG_Pascal83 as
	Pascal language marker.
	* dwarf2read.c (set_cu_language): Likewise.

(wrap at a reasonable width, leave off "gdb/" prefix because the entry
goes in gdb/ChangeLog).

Pierre, is there any way we can get some Pascal tests into the
testsuite?  I can find a working compiler to test with if we had some
tests.


-- 
Daniel Jacobowitz
CodeSourcery

Re: [RFA] Set pascal language for DWarf debug information

[Pierre Muller]

I committed the patch.

I also added a reference to the bug in the database as
  Fix PR pascal/2223.

From looking into older ChangeLog's I assumed that
that the bug category should be used for the first part.

  Concerning the testsuite, it would be nice indeed to have at least some 
tests
but the problem is that I don't know anything about the tests,
and when I tried to run the tests on my cygwin cvs,
it did nothing... 
  I tried to checkout the dejagnu directory,
but it seems to be almost empty.

  Is it possible to use the testsuite on Cygwin, and how do I
enable it?

Pierre Muller

----- Original Message ----- 
From: "Daniel Jacobowitz" <drow@false.org>
To: "Pierre Muller" <muller@ics.u-strasbg.fr>
Cc: <gdb-patches@sourceware.org>; <ezannoni@redhat.com>
Sent: Thursday, February 08, 2007 7:02 PM
Subject: Re: [RFA] Set pascal language for DWarf debug information


> On Mon, Feb 05, 2007 at 05:13:01PM +0100, Pierre Muller wrote:
>>  I extended his proposed patch to dwarfread.c file also.
>
> Might as well - but we will be deleting that file very shortly.
>
>>  I can see no risks associated with the given patch,
>> and I hope that, despite the long time since my last
>> RFA, it is formatted correctly.
>>  It is in a way, pascal specific, but as it is
>> not in a pascal only file, I prefer to get approval
>> before committing.
>
> Thanks.  The patch is OK, with an adjusted ChangeLog entry:
>
>> 2007-02-05  Pierre Muller  <muller@ics.u-strasbg.fr>
>>
>>         * gdb/dwarfread.c (set_cu_language): Recognize LANG_PASCAL83 as
>> pascal language marker.
>>         * gdb/dwarf2read.c (set_cu_language): Recognize DW_LANG_Pascal83
>> as pascal language marker.
>
> * dwarfread.c (set_cu_language): Recognize DW_LANG_Pascal83 as
> Pascal language marker.
> * dwarf2read.c (set_cu_language): Likewise.
>
> (wrap at a reasonable width, leave off "gdb/" prefix because the entry
> goes in gdb/ChangeLog).
>
> Pierre, is there any way we can get some Pascal tests into the
> testsuite?  I can find a working compiler to test with if we had some
> tests.
>
>
> -- 
> Daniel Jacobowitz
> CodeSourcery
>
> 

Re: [RFA] Set pascal language for DWarf debug information

[Daniel Jacobowitz]

On Mon, Feb 12, 2007 at 05:22:37PM +0100, Pierre Muller wrote:
>  Concerning the testsuite, it would be nice indeed to have at least some 
> tests
> but the problem is that I don't know anything about the tests,
> and when I tried to run the tests on my cygwin cvs,
> it did nothing... 
>  I tried to checkout the dejagnu directory,
> but it seems to be almost empty.
> 
>  Is it possible to use the testsuite on Cygwin, and how do I
> enable it?

Sure.  Install the Cygwin packages of dejagnu and expect, and then run
"make check-gdb", and then I would expect it to work.

I can help you write tests.  The Fortran ones might be a good model to
start from.

-- 
Daniel Jacobowitz
CodeSourcery