From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10140 invoked by alias); 8 Feb 2007 18:03:13 -0000 Received: (qmail 10110 invoked by uid 22791); 8 Feb 2007 18:03:08 -0000 X-Spam-Check-By: sourceware.org Received: from nevyn.them.org (HELO nevyn.them.org) (66.93.172.17) by sourceware.org (qpsmtpd/0.31.1) with ESMTP; Thu, 08 Feb 2007 18:02:59 +0000 Received: from drow by nevyn.them.org with local (Exim 4.63) (envelope-from ) id 1HFDbk-0004nE-BG; Thu, 08 Feb 2007 13:02:56 -0500 Date: Thu, 08 Feb 2007 18:03:00 -0000 From: Daniel Jacobowitz To: Pierre Muller Cc: gdb-patches@sourceware.org, ezannoni@redhat.com Subject: Re: [RFA] Set pascal language for DWarf debug information Message-ID: <20070208180256.GB17845@nevyn.them.org> Mail-Followup-To: Pierre Muller , gdb-patches@sourceware.org, ezannoni@redhat.com References: <1755.130.79.112.72.1170691981.squirrel@www-ics.u-strasbg.fr> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1755.130.79.112.72.1170691981.squirrel@www-ics.u-strasbg.fr> User-Agent: Mutt/1.5.13 (2006-08-11) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-02/txt/msg00090.txt.bz2 On Mon, Feb 05, 2007 at 05:13:01PM +0100, Pierre Muller wrote: > I extended his proposed patch to dwarfread.c file also. Might as well - but we will be deleting that file very shortly. > I can see no risks associated with the given patch, > and I hope that, despite the long time since my last > RFA, it is formatted correctly. > It is in a way, pascal specific, but as it is > not in a pascal only file, I prefer to get approval > before committing. Thanks. The patch is OK, with an adjusted ChangeLog entry: > 2007-02-05 Pierre Muller > > * gdb/dwarfread.c (set_cu_language): Recognize LANG_PASCAL83 as > pascal language marker. > * gdb/dwarf2read.c (set_cu_language): Recognize DW_LANG_Pascal83 > as pascal language marker. * dwarfread.c (set_cu_language): Recognize DW_LANG_Pascal83 as Pascal language marker. * dwarf2read.c (set_cu_language): Likewise. (wrap at a reasonable width, leave off "gdb/" prefix because the entry goes in gdb/ChangeLog). Pierre, is there any way we can get some Pascal tests into the testsuite? I can find a working compiler to test with if we had some tests. -- Daniel Jacobowitz CodeSourcery