Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: "Pierre Muller" <muller@ics.u-strasbg.fr>
To: "Daniel Jacobowitz" <drow@false.org>
Cc: <gdb-patches@sourceware.org>, 	<ezannoni@redhat.com>
Subject: Re: [RFA] Set pascal language for DWarf debug information
Date: Mon, 12 Feb 2007 16:22:00 -0000	[thread overview]
Message-ID: <000a01c74ec2$028c2770$48704f82@ICSMULLER> (raw)
In-Reply-To: <20070208180256.GB17845@nevyn.them.org>

I committed the patch.

I also added a reference to the bug in the database as
  Fix PR pascal/2223.

From looking into older ChangeLog's I assumed that
that the bug category should be used for the first part.

  Concerning the testsuite, it would be nice indeed to have at least some 
tests
but the problem is that I don't know anything about the tests,
and when I tried to run the tests on my cygwin cvs,
it did nothing... 
  I tried to checkout the dejagnu directory,
but it seems to be almost empty.

  Is it possible to use the testsuite on Cygwin, and how do I
enable it?

Pierre Muller

----- Original Message ----- 
From: "Daniel Jacobowitz" <drow@false.org>
To: "Pierre Muller" <muller@ics.u-strasbg.fr>
Cc: <gdb-patches@sourceware.org>; <ezannoni@redhat.com>
Sent: Thursday, February 08, 2007 7:02 PM
Subject: Re: [RFA] Set pascal language for DWarf debug information


> On Mon, Feb 05, 2007 at 05:13:01PM +0100, Pierre Muller wrote:
>>  I extended his proposed patch to dwarfread.c file also.
>
> Might as well - but we will be deleting that file very shortly.
>
>>  I can see no risks associated with the given patch,
>> and I hope that, despite the long time since my last
>> RFA, it is formatted correctly.
>>  It is in a way, pascal specific, but as it is
>> not in a pascal only file, I prefer to get approval
>> before committing.
>
> Thanks.  The patch is OK, with an adjusted ChangeLog entry:
>
>> 2007-02-05  Pierre Muller  <muller@ics.u-strasbg.fr>
>>
>>         * gdb/dwarfread.c (set_cu_language): Recognize LANG_PASCAL83 as
>> pascal language marker.
>>         * gdb/dwarf2read.c (set_cu_language): Recognize DW_LANG_Pascal83
>> as pascal language marker.
>
> * dwarfread.c (set_cu_language): Recognize DW_LANG_Pascal83 as
> Pascal language marker.
> * dwarf2read.c (set_cu_language): Likewise.
>
> (wrap at a reasonable width, leave off "gdb/" prefix because the entry
> goes in gdb/ChangeLog).
>
> Pierre, is there any way we can get some Pascal tests into the
> testsuite?  I can find a working compiler to test with if we had some
> tests.
>
>
> -- 
> Daniel Jacobowitz
> CodeSourcery
>
> 



  reply	other threads:[~2007-02-12 16:22 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-02-05 16:16 Pierre Muller
2007-02-08 18:03 ` Daniel Jacobowitz
2007-02-12 16:22   ` Pierre Muller [this message]
2007-02-12 17:02     ` Daniel Jacobowitz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='000a01c74ec2$028c2770$48704f82@ICSMULLER' \
    --to=muller@ics.u-strasbg.fr \
    --cc=drow@false.org \
    --cc=ezannoni@redhat.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox