From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24492 invoked by alias); 12 Feb 2007 16:22:36 -0000 Received: (qmail 24475 invoked by uid 22791); 12 Feb 2007 16:22:35 -0000 X-Spam-Check-By: sourceware.org Received: from ics.u-strasbg.fr (HELO ics.u-strasbg.fr) (130.79.112.250) by sourceware.org (qpsmtpd/0.31) with ESMTP; Mon, 12 Feb 2007 16:22:28 +0000 Received: from ICSMULLER (laocoon.u-strasbg.fr [130.79.112.72]) by ics.u-strasbg.fr (Postfix) with SMTP id CB1AF187026; Mon, 12 Feb 2007 17:25:12 +0100 (CET) Message-ID: <000a01c74ec2$028c2770$48704f82@ICSMULLER> From: "Pierre Muller" To: "Daniel Jacobowitz" Cc: , References: <1755.130.79.112.72.1170691981.squirrel@www-ics.u-strasbg.fr> <20070208180256.GB17845@nevyn.them.org> Subject: Re: [RFA] Set pascal language for DWarf debug information Date: Mon, 12 Feb 2007 16:22:00 -0000 MIME-Version: 1.0 Content-Type: text/plain; format=flowed; charset="iso-8859-1"; reply-type=original Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Outlook Express 6.00.2900.2869 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-02/txt/msg00170.txt.bz2 I committed the patch. I also added a reference to the bug in the database as Fix PR pascal/2223. >From looking into older ChangeLog's I assumed that that the bug category should be used for the first part. Concerning the testsuite, it would be nice indeed to have at least some tests but the problem is that I don't know anything about the tests, and when I tried to run the tests on my cygwin cvs, it did nothing... I tried to checkout the dejagnu directory, but it seems to be almost empty. Is it possible to use the testsuite on Cygwin, and how do I enable it? Pierre Muller ----- Original Message ----- From: "Daniel Jacobowitz" To: "Pierre Muller" Cc: ; Sent: Thursday, February 08, 2007 7:02 PM Subject: Re: [RFA] Set pascal language for DWarf debug information > On Mon, Feb 05, 2007 at 05:13:01PM +0100, Pierre Muller wrote: >> I extended his proposed patch to dwarfread.c file also. > > Might as well - but we will be deleting that file very shortly. > >> I can see no risks associated with the given patch, >> and I hope that, despite the long time since my last >> RFA, it is formatted correctly. >> It is in a way, pascal specific, but as it is >> not in a pascal only file, I prefer to get approval >> before committing. > > Thanks. The patch is OK, with an adjusted ChangeLog entry: > >> 2007-02-05 Pierre Muller >> >> * gdb/dwarfread.c (set_cu_language): Recognize LANG_PASCAL83 as >> pascal language marker. >> * gdb/dwarf2read.c (set_cu_language): Recognize DW_LANG_Pascal83 >> as pascal language marker. > > * dwarfread.c (set_cu_language): Recognize DW_LANG_Pascal83 as > Pascal language marker. > * dwarf2read.c (set_cu_language): Likewise. > > (wrap at a reasonable width, leave off "gdb/" prefix because the entry > goes in gdb/ChangeLog). > > Pierre, is there any way we can get some Pascal tests into the > testsuite? I can find a working compiler to test with if we had some > tests. > > > -- > Daniel Jacobowitz > CodeSourcery > >