Re: [rfa/symtab] Move find_pc_section call to lookup_minimal_symbol_by_pc

[Elena Zannoni <ezannoni@redhat.com>]

Adam Fedor writes:

 > +2004-01-29  Adam Fedor  <fedor@gnu.org>
 > +
 > +	* gdb.base/ppc-shared.exp: New file.
 > +	* gdb.base/ppc-main.c, gdb.base/ppc-shared.c: New files.
 > +


I would just name these files with the PR number, since the test is generic.
The other problem (runaway with next) should have its own set of files.


 > Index: gdb.base/ppc-main.c
 > ===================================================================
 > RCS file: gdb.base/ppc-main.c
 > diff -N gdb.base/ppc-main.c
 > --- /dev/null	1 Jan 1970 00:00:00 -0000
 > +++ gdb.base/ppc-main.c	30 Jan 2004 04:50:33 -0000
 > @@ -0,0 +1,8 @@
 > +extern int hithere2 ();
 > +
 > +int
 > +main()
 > +{
 > +  hithere2();
 > +  return 0;
 > +}
 > Index: gdb.base/ppc-shared.c
 > ===================================================================
 > RCS file: gdb.base/ppc-shared.c
 > diff -N gdb.base/ppc-shared.c
 > --- /dev/null	1 Jan 1970 00:00:00 -0000
 > +++ gdb.base/ppc-shared.c	30 Jan 2004 04:50:33 -0000
 > @@ -0,0 +1,5 @@
 > +int hithere2()
 > +{
 > +  return 21;
 > +}
 > +
 > Index: gdb.base/ppc-shared.exp
 > ===================================================================
 > RCS file: gdb.base/ppc-shared.exp
 > diff -N gdb.base/ppc-shared.exp
 > --- /dev/null	1 Jan 1970 00:00:00 -0000
 > +++ gdb.base/ppc-shared.exp	30 Jan 2004 04:50:33 -0000
 > @@ -0,0 +1,98 @@
 > +# Copyright 2003 Free Software Foundation, Inc.
 > +
 > +# This program is free software; you can redistribute it and/or modify
 > +# it under the terms of the GNU General Public License as published by
 > +# the Free Software Foundation; either version 2 of the License, or
 > +# (at your option) any later version.
 > +# 
 > +# This program is distributed in the hope that it will be useful,
 > +# but WITHOUT ANY WARRANTY; without even the implied warranty of
 > +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 > +# GNU General Public License for more details.
 > +# 
 > +# You should have received a copy of the GNU General Public License
 > +# along with this program; if not, write to the Free Software
 > +# Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA.  */
 > +
 > +# Please email any bugs, comments, and/or additions to this file to:
 > +# bug-gdb@prep.ai.mit.edu
 > +
 > +# ppc-shared.exp -- Test stepping into and continuing to a function in
 > +# a shared library (PR shlib/1280, shlib/1237).


This is only testing the step. And it's fine for 1280. I would do a
separate set of files for 1237.

Probably use kfail too.

Remember the copyright notices in the new .c files. And the correct
year (years, if derived from another file).

elena