From: Elena Zannoni <ezannoni@redhat.com>
To: Andrew Cagney <cagney@gnu.org>, fedor@doc.com
Cc: gdb-patches@sources.redhat.com
Subject: Re: [rfa/symtab] Move find_pc_section call to lookup_minimal_symbol_by_pc
Date: Thu, 29 Jan 2004 20:15:00 -0000 [thread overview]
Message-ID: <16409.26976.292424.689823@localhost.redhat.com> (raw)
In-Reply-To: <4016E401.2050001@gnu.org>
Andrew Cagney writes:
> Hello,
>
> Ref: RFA symtab: Fix for PR c++/1267 ("next" and shared libraries)
> http://sources.redhat.com/ml/gdb-patches/2003-07/msg00354.html
>
> The change unfortunatly broke IRIX 6.5's host compiler which is using
> mdebugread :-( That code was looking for a symbol in the absolute
> section "*ABS*" but the PR/1267 change was causing *ABS* symbols to be
> ignored (find_pc_section didn't return an absolute section).
>
> Since the underlying problem with PR/1267 was with the frame code
> needing a minimal symbol that was in the same section as the frame's PC,
> and that code [indirectly] calls lookup_minimal_symbol_by_pc, I moved
> the find_pc_section call to that function.
>
> Tested on i386 GNU/Linux (dwarf 2) with no regressions.
> Tested on PPC NetBSD (stabs) with no regressions.
> Tested on IRIX and all the warnings, and many failures, disappeared.
> See gdb/1519 for how to exercise the bug.
>
> ok?
ok. Does it still fix shlibs/1237 and shlibs/1280 too? Adam, could you
check please?
elena
next prev parent reply other threads:[~2004-01-29 20:15 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-01-27 22:23 Andrew Cagney
2004-01-27 22:52 ` Daniel Jacobowitz
2004-01-29 20:15 ` Elena Zannoni [this message]
2004-01-29 23:22 ` Andrew Cagney
2004-01-30 3:30 ` Adam Fedor
2004-01-30 4:53 ` Adam Fedor
2004-02-04 22:25 ` Elena Zannoni
2004-02-09 4:26 ` Adam Fedor
2004-02-09 15:31 ` Elena Zannoni
2004-01-30 3:29 ` Adam Fedor
2004-02-04 22:20 ` Elena Zannoni
2004-02-04 23:06 ` Andrew Cagney
2004-02-06 18:59 ` Andrew Cagney
2004-02-08 5:17 ` Adam Fedor
2004-02-09 15:35 ` Elena Zannoni
2004-02-09 16:40 ` Andrew Cagney
2004-02-09 17:54 ` Joel Brobecker
2004-02-09 21:58 Michael Elizabeth Chastain
2004-02-10 16:38 ` Adam Fedor
2004-02-16 18:11 ` Elena Zannoni
2004-02-17 4:47 ` Adam Fedor
2004-02-17 5:00 ` Daniel Jacobowitz
2004-02-17 14:23 ` Elena Zannoni
2004-02-18 3:40 ` Adam Fedor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=16409.26976.292424.689823@localhost.redhat.com \
--to=ezannoni@redhat.com \
--cc=cagney@gnu.org \
--cc=fedor@doc.com \
--cc=gdb-patches@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox