From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11347 invoked by alias); 4 Feb 2004 22:25:18 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 11337 invoked from network); 4 Feb 2004 22:25:17 -0000 Received: from unknown (HELO localhost.redhat.com) (66.30.197.194) by sources.redhat.com with SMTP; 4 Feb 2004 22:25:17 -0000 Received: by localhost.redhat.com (Postfix, from userid 469) id 03CB71A4412; Wed, 4 Feb 2004 17:22:19 -0500 (EST) From: Elena Zannoni MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <16417.28827.748483.614684@localhost.redhat.com> Date: Wed, 04 Feb 2004 22:25:00 -0000 To: Adam Fedor Cc: "gdb-patches@sources.redhat.com" , Elena Zannoni , Andrew Cagney Subject: Re: [rfa/symtab] Move find_pc_section call to lookup_minimal_symbol_by_pc In-Reply-To: <1075438401.29218.20.camel@localhost.localdomain> References: <4016E401.2050001@gnu.org> <16409.26976.292424.689823@localhost.redhat.com> <401994EE.9060306@gnu.org> <1075438401.29218.20.camel@localhost.localdomain> X-SW-Source: 2004-02/txt/msg00083.txt.bz2 Adam Fedor writes: > +2004-01-29 Adam Fedor > + > + * gdb.base/ppc-shared.exp: New file. > + * gdb.base/ppc-main.c, gdb.base/ppc-shared.c: New files. > + I would just name these files with the PR number, since the test is generic. The other problem (runaway with next) should have its own set of files. > Index: gdb.base/ppc-main.c > =================================================================== > RCS file: gdb.base/ppc-main.c > diff -N gdb.base/ppc-main.c > --- /dev/null 1 Jan 1970 00:00:00 -0000 > +++ gdb.base/ppc-main.c 30 Jan 2004 04:50:33 -0000 > @@ -0,0 +1,8 @@ > +extern int hithere2 (); > + > +int > +main() > +{ > + hithere2(); > + return 0; > +} > Index: gdb.base/ppc-shared.c > =================================================================== > RCS file: gdb.base/ppc-shared.c > diff -N gdb.base/ppc-shared.c > --- /dev/null 1 Jan 1970 00:00:00 -0000 > +++ gdb.base/ppc-shared.c 30 Jan 2004 04:50:33 -0000 > @@ -0,0 +1,5 @@ > +int hithere2() > +{ > + return 21; > +} > + > Index: gdb.base/ppc-shared.exp > =================================================================== > RCS file: gdb.base/ppc-shared.exp > diff -N gdb.base/ppc-shared.exp > --- /dev/null 1 Jan 1970 00:00:00 -0000 > +++ gdb.base/ppc-shared.exp 30 Jan 2004 04:50:33 -0000 > @@ -0,0 +1,98 @@ > +# Copyright 2003 Free Software Foundation, Inc. > + > +# This program is free software; you can redistribute it and/or modify > +# it under the terms of the GNU General Public License as published by > +# the Free Software Foundation; either version 2 of the License, or > +# (at your option) any later version. > +# > +# This program is distributed in the hope that it will be useful, > +# but WITHOUT ANY WARRANTY; without even the implied warranty of > +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > +# GNU General Public License for more details. > +# > +# You should have received a copy of the GNU General Public License > +# along with this program; if not, write to the Free Software > +# Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA. */ > + > +# Please email any bugs, comments, and/or additions to this file to: > +# bug-gdb@prep.ai.mit.edu > + > +# ppc-shared.exp -- Test stepping into and continuing to a function in > +# a shared library (PR shlib/1280, shlib/1237). This is only testing the step. And it's fine for 1280. I would do a separate set of files for 1237. Probably use kfail too. Remember the copyright notices in the new .c files. And the correct year (years, if derived from another file). elena