[RFC] unneeded extra brace in infrun.c (handle_inferior_event)

[RFC] unneeded extra brace in infrun.c (handle_inferior_event)

[Joel Brobecker]

While reading the code, I found this comment along the extra unneeded
brace:

     /* Keep this extra brace for now, minimizes diffs.  */
     {

This brace causes an extra 2 characters indentation to the right for the
entire function (which is quite long, actually).  No big deal, but it
would take me very little time to remove it if that's useful. Shall I do
it?

-- 
Joel

Re: [RFC] unneeded extra brace in infrun.c (handle_inferior_event)

[Elena Zannoni]

Joel Brobecker writes:
 > While reading the code, I found this comment along the extra unneeded
 > brace:
 > 
 >      /* Keep this extra brace for now, minimizes diffs.  */
 >      {
 > 
 > This brace causes an extra 2 characters indentation to the right for the
 > entire function (which is quite long, actually).  No big deal, but it
 > would take me very little time to remove it if that's useful. Shall I do
 > it?
 > 
 > -- 
 > Joel

I remember that! (Does that mean I am becoming an old timer? Oh dear.)
The comment was introduced by Stan when he did some major cleanup of
this function (at the time called wait_for_inferior).  There were so
many changes that adding formatting changes would have made really
difficult to track (and back possibly back out) all the functional
ones.

I vote for reindenting the code. Infrun.c has been on the quiet side
for a bit, and I don't think this change will cause any problems.

Elena

Re: [RFC] unneeded extra brace in infrun.c (handle_inferior_event)

[Joel Brobecker]

> I vote for reindenting the code. Infrun.c has been on the quiet side
> for a bit, and I don't think this change will cause any problems.

I can do the following, all within a short period:
  - remove the braces (without indentation change)
  - commit
  - run gdb_indent.sh
  - commit
  
That way, we have one commit which contains a code change, but the diff
is readable. The second diff may be unreadable, but will contain no code
change.

Should I go ahead?
-- 
Joel

Re: [RFC] unneeded extra brace in infrun.c (handle_inferior_event)

[Kevin Buettner]

On Jul 16,  4:30pm, Joel Brobecker wrote:

> I can do the following, all within a short period:
>   - remove the braces (without indentation change)
>   - commit
>   - run gdb_indent.sh
>   - commit
>   
> That way, we have one commit which contains a code change, but the diff
> is readable. The second diff may be unreadable, but will contain no code
> change.
> 
> Should I go ahead?

Sounds okay to me...

(I'd say go ahead provided you get a couple more "yes" votes and no
objections.)

Kevin

Re: [RFC] unneeded extra brace in infrun.c (handle_inferior_event)

[Elena Zannoni]

Kevin Buettner writes:
 > On Jul 16,  4:30pm, Joel Brobecker wrote:
 > 
 > > I can do the following, all within a short period:
 > >   - remove the braces (without indentation change)
 > >   - commit
 > >   - run gdb_indent.sh
 > >   - commit
 > >   
 > > That way, we have one commit which contains a code change, but the diff
 > > is readable. The second diff may be unreadable, but will contain no code
 > > change.
 > > 
 > > Should I go ahead?
 > 
 > Sounds okay to me...
 > 
 > (I'd say go ahead provided you get a couple more "yes" votes and no
 > objections.)

It had my vote. I would just go ahead (post the diffs, though).

Elena


 > 
 > Kevin

Re: [RFC] unneeded extra brace in infrun.c (handle_inferior_event)

[Elena Zannoni]

Elena Zannoni writes:
 > Kevin Buettner writes:
 >  > On Jul 16,  4:30pm, Joel Brobecker wrote:
 >  > 
 >  > > I can do the following, all within a short period:
 >  > >   - remove the braces (without indentation change)
 >  > >   - commit
 >  > >   - run gdb_indent.sh
 >  > >   - commit
 >  > >   
 >  > > That way, we have one commit which contains a code change, but the diff
 >  > > is readable. The second diff may be unreadable, but will contain no code
 >  > > change.
 >  > > 
 >  > > Should I go ahead?
 >  > 
 >  > Sounds okay to me...
 >  > 
 >  > (I'd say go ahead provided you get a couple more "yes" votes and no
 >  > objections.)
 > 
 > It had my vote. I would just go ahead (post the diffs, though).
 > 

I mean, this would give people time to object. Wait until the next day
before committing.

 > Elena
 > 
 > 
 >  > 
 >  > Kevin