From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23703 invoked by alias); 17 Jul 2002 02:00:41 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 23693 invoked from network); 17 Jul 2002 02:00:40 -0000 Received: from unknown (HELO localhost.redhat.com) (66.30.197.194) by sources.redhat.com with SMTP; 17 Jul 2002 02:00:40 -0000 Received: by localhost.redhat.com (Postfix, from userid 469) id A3E8D108C9; Tue, 16 Jul 2002 21:59:06 -0400 (EDT) From: Elena Zannoni MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <15668.53098.529354.370738@localhost.redhat.com> Date: Tue, 16 Jul 2002 20:32:00 -0000 To: gdb-patches@sources.redhat.com Cc: Kevin Buettner , Joel Brobecker Subject: Re: [RFC] unneeded extra brace in infrun.c (handle_inferior_event) In-Reply-To: <15668.51645.791703.967626@localhost.redhat.com> References: <20020716204432.GE2700@gnat.com> <15668.35195.754595.953902@localhost.redhat.com> <20020716233039.GG2700@gnat.com> <1020716235933.ZM11697@localhost.localdomain> <15668.51645.791703.967626@localhost.redhat.com> X-SW-Source: 2002-07/txt/msg00362.txt.bz2 Elena Zannoni writes: > Kevin Buettner writes: > > On Jul 16, 4:30pm, Joel Brobecker wrote: > > > > > I can do the following, all within a short period: > > > - remove the braces (without indentation change) > > > - commit > > > - run gdb_indent.sh > > > - commit > > > > > > That way, we have one commit which contains a code change, but the diff > > > is readable. The second diff may be unreadable, but will contain no code > > > change. > > > > > > Should I go ahead? > > > > Sounds okay to me... > > > > (I'd say go ahead provided you get a couple more "yes" votes and no > > objections.) > > It had my vote. I would just go ahead (post the diffs, though). > I mean, this would give people time to object. Wait until the next day before committing. > Elena > > > > > > Kevin