From: Elena Zannoni <ezannoni@redhat.com>
To: Joel Brobecker <brobecker@gnat.com>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [RFC] unneeded extra brace in infrun.c (handle_inferior_event)
Date: Tue, 16 Jul 2002 14:09:00 -0000 [thread overview]
Message-ID: <15668.35195.754595.953902@localhost.redhat.com> (raw)
In-Reply-To: <20020716204432.GE2700@gnat.com>
Joel Brobecker writes:
> While reading the code, I found this comment along the extra unneeded
> brace:
>
> /* Keep this extra brace for now, minimizes diffs. */
> {
>
> This brace causes an extra 2 characters indentation to the right for the
> entire function (which is quite long, actually). No big deal, but it
> would take me very little time to remove it if that's useful. Shall I do
> it?
>
> --
> Joel
I remember that! (Does that mean I am becoming an old timer? Oh dear.)
The comment was introduced by Stan when he did some major cleanup of
this function (at the time called wait_for_inferior). There were so
many changes that adding formatting changes would have made really
difficult to track (and back possibly back out) all the functional
ones.
I vote for reindenting the code. Infrun.c has been on the quiet side
for a bit, and I don't think this change will cause any problems.
Elena
next prev parent reply other threads:[~2002-07-16 21:02 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-07-16 14:02 Joel Brobecker
2002-07-16 14:09 ` Elena Zannoni [this message]
2002-07-16 16:59 ` Joel Brobecker
2002-07-16 17:17 ` Kevin Buettner
2002-07-16 19:00 ` Elena Zannoni
2002-07-16 20:32 ` Elena Zannoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=15668.35195.754595.953902@localhost.redhat.com \
--to=ezannoni@redhat.com \
--cc=brobecker@gnat.com \
--cc=gdb-patches@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox