Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Joel Brobecker <brobecker@gnat.com>
To: Elena Zannoni <ezannoni@redhat.com>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [RFC] unneeded extra brace in infrun.c (handle_inferior_event)
Date: Tue, 16 Jul 2002 16:59:00 -0000	[thread overview]
Message-ID: <20020716233039.GG2700@gnat.com> (raw)
In-Reply-To: <15668.35195.754595.953902@localhost.redhat.com>

> I vote for reindenting the code. Infrun.c has been on the quiet side
> for a bit, and I don't think this change will cause any problems.

I can do the following, all within a short period:
  - remove the braces (without indentation change)
  - commit
  - run gdb_indent.sh
  - commit
  
That way, we have one commit which contains a code change, but the diff
is readable. The second diff may be unreadable, but will contain no code
change.

Should I go ahead?
-- 
Joel


  reply	other threads:[~2002-07-16 23:30 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-07-16 14:02 Joel Brobecker
2002-07-16 14:09 ` Elena Zannoni
2002-07-16 16:59   ` Joel Brobecker [this message]
2002-07-16 17:17     ` Kevin Buettner
2002-07-16 19:00       ` Elena Zannoni
2002-07-16 20:32         ` Elena Zannoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20020716233039.GG2700@gnat.com \
    --to=brobecker@gnat.com \
    --cc=ezannoni@redhat.com \
    --cc=gdb-patches@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox