GDB 8.2 branch WEDNESDAY? (2018-07-02 update)

GDB 8.2 branch WEDNESDAY? (2018-07-02 update)

[Joel Brobecker]

Hi everyone,

Fixed since the last update:

  * (JoelB) SEGV on x86_64-windows due to fs_base/gs_base

Still in progress:

  * (PhilippeW) Implement 'frame apply COMMAND', enhance 'thread apply COMMAND'
    v3 sent on June 24th:
    https://www.sourceware.org/ml/gdb-patches/2018-06/msg00559.html

    At this point, it looks to me like there are still some questions
    related to the new command-line interface itself, so it seems
    better to give our the time to think this through. Let's keep
    the pressure on, to get this patch series over the hump, but
    let's also give ourselves the opportunity to observe the patch
    in the master branch for a while before it makes it to a release.

Not blocking for the branch, but requested as nice to have:

  * (AlanH) core file suport for aarch64 SVE
    https://www.sourceware.org/ml/gdb-patches/2018-06/msg00580.html
    ping: https://www.sourceware.org/ml/gdb-patches/2018-07/msg00015.html

The other two known issues are not blocking, IMO:

  * (KevinB) gdb/23021 - Setting breakpoints with -freorder-blocks-and-partition
    Not a regression, easy workaround.
    https://sourceware.org/bugzilla/show_bug.cgi?id=23021

  * (MaciejR) tdep/8282 - MIPS port needs `set disassembler-options'
    Enhancement.
    https://sourceware.org/bugzilla/show_bug.cgi?id=8282

All in all, I think we should go ahead and create the branch Wednesday.
We can still backport some patches if they are shown to have some benefit
while being reasonably safe or having a limited impact.

Thanks!
-- 
Joel

Re: GDB 8.2 branch WEDNESDAY? (2018-07-02 update)

[Philippe Waroquiers]

On Mon, 2018-07-02 at 13:18 -0700, Joel Brobecker wrote:
> Still in progress:
> 
>   * (PhilippeW) Implement 'frame apply COMMAND', enhance 'thread apply COMMAND'
>     v3 sent on June 24th:
>     https://www.sourceware.org/ml/gdb-patches/2018-06/msg00559.html
> 
>     At this point, it looks to me like there are still some questions
>     related to the new command-line interface itself, so it seems
>     better to give our the time to think this through. Let's keep
>     the pressure on, to get this patch series over the hump, but
>     let's also give ourselves the opportunity to observe the patch
>     in the master branch for a while before it makes it to a release.
To my knowledge, v3 implements all what was discussed with Pedro.
However, we still have a question related to the 'compatibility'
between this patch and the patch
  https://sourceware.org/ml/gdb-patches/2018-06/msg00170.html
regarding using 'id' or 'level' to identify a frame.

So, effectively, we better agree on that aspect before pushing
(in the master branch then) ...

Thanks

Philippe

Re: GDB 8.2 branch WEDNESDAY? (2018-07-02 update)

[Joel Brobecker]

> >   * (PhilippeW) Implement 'frame apply COMMAND', enhance 'thread apply COMMAND'
> >     v3 sent on June 24th:
> >     https://www.sourceware.org/ml/gdb-patches/2018-06/msg00559.html
> > 
> >     At this point, it looks to me like there are still some questions
> >     related to the new command-line interface itself, so it seems
> >     better to give our the time to think this through. Let's keep
> >     the pressure on, to get this patch series over the hump, but
> >     let's also give ourselves the opportunity to observe the patch
> >     in the master branch for a while before it makes it to a release.
> To my knowledge, v3 implements all what was discussed with Pedro.
> However, we still have a question related to the 'compatibility'
> between this patch and the patch
>   https://sourceware.org/ml/gdb-patches/2018-06/msg00170.html
> regarding using 'id' or 'level' to identify a frame.
> 
> So, effectively, we better agree on that aspect before pushing
> (in the master branch then) ...

That is indeed my main concern, and considering the proposed branching
date, I am thinking it might be tight to get an agreement. And if we
do get an agreement in time, would it make sense to wait after the
branch or not? I haven't followed the thread very closely, so I'll
defer to your judgement as well as the Pedro's.

-- 
Joel

Re: GDB 8.2 branch WEDNESDAY? (2018-07-02 update)

[Maciej W. Rozycki]

Hi Joel,

>   * (MaciejR) tdep/8282 - MIPS port needs `set disassembler-options'
>     Enhancement.
>     https://sourceware.org/bugzilla/show_bug.cgi?id=8282

 Now committed, so not a concern anymore.

  Maciej

Re: GDB 8.2 branch WEDNESDAY? (2018-07-02 update)

[Philippe Waroquiers]

On Mon, 2018-07-02 at 15:12 -0700, Joel Brobecker wrote:
> > >   * (PhilippeW) Implement 'frame apply COMMAND', enhance 'thread apply COMMAND'
> > >     v3 sent on June 24th:
> > >     https://www.sourceware.org/ml/gdb-patches/2018-06/msg00559.html
> > > 
> > >     At this point, it looks to me like there are still some questions
> > >     related to the new command-line interface itself, so it seems
> > >     better to give our the time to think this through. Let's keep
> > >     the pressure on, to get this patch series over the hump, but
> > >     let's also give ourselves the opportunity to observe the patch
> > >     in the master branch for a while before it makes it to a release.
> > 
> > To my knowledge, v3 implements all what was discussed with Pedro.
> > However, we still have a question related to the 'compatibility'
> > between this patch and the patch
> >   https://sourceware.org/ml/gdb-patches/2018-06/msg00170.html
> > regarding using 'id' or 'level' to identify a frame.
> > 
> > So, effectively, we better agree on that aspect before pushing
> > (in the master branch then) ...
> 
> That is indeed my main concern, and considering the proposed branching
> date, I am thinking it might be tight to get an agreement. And if we
> do get an agreement in time, would it make sense to wait after the
> branch or not? I haven't followed the thread very closely, so I'll
> defer to your judgement as well as the Pedro's.

IMO, it would make sense to wait after the branch, so as to have
time to see the 2 patches together in the master branch, and adjust
if needed.
But I will not too strongly object if Pedro is really keen on pushing
it in earlier :).

Philippe

Re: GDB 8.2 branch WEDNESDAY? (2018-07-02 update)

[Pedro Alves]

On 07/03/2018 05:03 AM, Philippe Waroquiers wrote:
> On Mon, 2018-07-02 at 15:12 -0700, Joel Brobecker wrote:
>>>>   * (PhilippeW) Implement 'frame apply COMMAND', enhance 'thread apply COMMAND'
>>>>     v3 sent on June 24th:
>>>>     https://www.sourceware.org/ml/gdb-patches/2018-06/msg00559.html
>>>>
>>>>     At this point, it looks to me like there are still some questions
>>>>     related to the new command-line interface itself, so it seems
>>>>     better to give our the time to think this through. Let's keep
>>>>     the pressure on, to get this patch series over the hump, but
>>>>     let's also give ourselves the opportunity to observe the patch
>>>>     in the master branch for a while before it makes it to a release.
>>>
>>> To my knowledge, v3 implements all what was discussed with Pedro.
>>> However, we still have a question related to the 'compatibility'
>>> between this patch and the patch
>>>   https://sourceware.org/ml/gdb-patches/2018-06/msg00170.html
>>> regarding using 'id' or 'level' to identify a frame.
>>>
>>> So, effectively, we better agree on that aspect before pushing
>>> (in the master branch then) ...
>>
>> That is indeed my main concern, and considering the proposed branching
>> date, I am thinking it might be tight to get an agreement. And if we
>> do get an agreement in time, would it make sense to wait after the
>> branch or not? I haven't followed the thread very closely, so I'll
>> defer to your judgement as well as the Pedro's.
> 
> IMO, it would make sense to wait after the branch, so as to have
> time to see the 2 patches together in the master branch, and adjust
> if needed  

I agree, even though I feel a little guilty that the patches are taking
so long to be reviewed.  Sorry about that.

I would prefer to mature the patches on master personally, to avoid issues
with getting stuck with some user interface issue we may run into once
we get more exposure.

> But I will not too strongly object if Pedro is really keen on pushing
> it in earlier :).

I'm not.  :-)

I'm downloading the v3 series to start playing with it.  I'll try to
reply back soon.

Thanks,
Pedro Alves