[patch] Fix PR build/13372

[patch] Fix PR build/13372

[Ben Golding]

(Apologies I'm not familiar with the usual process for submitting patches...)

Bug: http://sourceware.org/bugzilla/show_bug.cgi?id=13372

Patch generated with diff -cp:
*** events.c~   Mon Feb 14 06:14:27 2011
--- events.c    Wed Nov  2 18:13:54 2011
***************
*** 26,31 ****
--- 26,32 ----
  #include "events.h"
  
  #include <signal.h>
+ #include <stdlib.h>
  
  #if !defined (SIM_EVENTS_POLL_RATE)
  #define SIM_EVENTS_POLL_RATE 0x1000


Changelog entry should read something like:
sim/ppc/
* events.c: add #include <stdlib.h> for free(). Fix PR build/13372.

Re: [patch] Fix PR build/13372

[Tom Tromey]

>>>>> "Ben" == Ben Golding <ben_golding@yahoo.co.uk> writes:

Ben> (Apologies I'm not familiar with the usual process for submitting
Ben> patches...)

No problem.

It is missing a ChangeLog entry.  Could you write one?  They are
described in the GNU coding standards and there are also many examples
in the tree.

Ben> Patch generated with diff -cp:

Patch looks reasonable to me.

Tom

Re: [patch] Fix PR build/13372

[Ben Golding]

[-- Attachment #1: Type: text/plain, Size: 928 bytes --]

Hi Tom,

I did include a ChangeLog entry in the email. But I've now tidied it up and applied to sim/ppc/ChangeLog, since I assume that's what is required.

Patch attached.
Hope this is now acceptable...

Ben



----- Original Message -----
> From: Tom Tromey <tromey@redhat.com>
> To: Ben Golding <ben_golding@yahoo.co.uk>
> Cc: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
> Sent: Wednesday, 2 November 2011, 18:39
> Subject: Re: [patch] Fix PR build/13372
> 
>>>>>>  "Ben" == Ben Golding 
> <ben_golding@yahoo.co.uk> writes:
> 
> Ben> (Apologies I'm not familiar with the usual process for submitting
> Ben> patches...)
> 
> No problem.
> 
> It is missing a ChangeLog entry.  Could you write one?  They are
> described in the GNU coding standards and there are also many examples
> in the tree.
> 
> Ben> Patch generated with diff -cp:
> 
> Patch looks reasonable to me.
> 
> Tom

[-- Attachment #2: gdb_PR_build_13372.patch --]
[-- Type: application/octet-stream, Size: 622 bytes --]

*** events.c~	Mon Feb 14 06:14:27 2011
--- events.c	Wed Nov  2 18:13:54 2011
***************
*** 26,31 ****
--- 26,32 ----
  #include "events.h"
  
  #include <signal.h>
+ #include <stdlib.h>
  
  #if !defined (SIM_EVENTS_POLL_RATE)
  #define SIM_EVENTS_POLL_RATE 0x1000
*** ChangeLog~	Thu Nov  3 15:48:38 2011
--- ChangeLog	Thu Nov  3 15:55:21 2011
***************
*** 1,3 ****
--- 1,7 ----
+ 2011-02-11  Ben Golding  <ben_golding@yahoo.co.uk>
+ 
+ 	* events.c: add #include <stdlib.h> for free(). Fix PR build/13372.
+ 
  2011-02-14  Mike Frysinger  <vapier@gentoo.org>
  
  	* cap.c (cap_remove): Change zfree to free.

Re: [patch] Fix PR build/13372

[Tom Tromey]

>>>>> "Ben" == Ben Golding <ben_golding@yahoo.co.uk> writes:

Ben> I did include a ChangeLog entry in the email. 

Oops, sorry, I didn't see it there.

Ben> But I've now tidied it up and applied to sim/ppc/ChangeLog, since I
Ben> assume that's what is required.

Thank you.

Ben> Patch attached.
Ben> Hope this is now acceptable...

I am checking it in.

If you plan to fix more problems I think you should get a copyright
assignment in place.  Contact me off-list to start this.

Tom