From: Ben Golding <ben_golding@yahoo.co.uk>
To: Tom Tromey <tromey@redhat.com>
Cc: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: [patch] Fix PR build/13372
Date: Thu, 03 Nov 2011 15:01:00 -0000 [thread overview]
Message-ID: <1320332452.80694.YahooMailNeo@web27507.mail.ukl.yahoo.com> (raw)
In-Reply-To: <m3y5vywepv.fsf@fleche.redhat.com>
[-- Attachment #1: Type: text/plain, Size: 928 bytes --]
Hi Tom,
I did include a ChangeLog entry in the email. But I've now tidied it up and applied to sim/ppc/ChangeLog, since I assume that's what is required.
Patch attached.
Hope this is now acceptable...
Ben
----- Original Message -----
> From: Tom Tromey <tromey@redhat.com>
> To: Ben Golding <ben_golding@yahoo.co.uk>
> Cc: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
> Sent: Wednesday, 2 November 2011, 18:39
> Subject: Re: [patch] Fix PR build/13372
>
>>>>>> "Ben" == Ben Golding
> <ben_golding@yahoo.co.uk> writes:
>
> Ben> (Apologies I'm not familiar with the usual process for submitting
> Ben> patches...)
>
> No problem.
>
> It is missing a ChangeLog entry. Could you write one? They are
> described in the GNU coding standards and there are also many examples
> in the tree.
>
> Ben> Patch generated with diff -cp:
>
> Patch looks reasonable to me.
>
> Tom
[-- Attachment #2: gdb_PR_build_13372.patch --]
[-- Type: application/octet-stream, Size: 622 bytes --]
*** events.c~ Mon Feb 14 06:14:27 2011
--- events.c Wed Nov 2 18:13:54 2011
***************
*** 26,31 ****
--- 26,32 ----
#include "events.h"
#include <signal.h>
+ #include <stdlib.h>
#if !defined (SIM_EVENTS_POLL_RATE)
#define SIM_EVENTS_POLL_RATE 0x1000
*** ChangeLog~ Thu Nov 3 15:48:38 2011
--- ChangeLog Thu Nov 3 15:55:21 2011
***************
*** 1,3 ****
--- 1,7 ----
+ 2011-02-11 Ben Golding <ben_golding@yahoo.co.uk>
+
+ * events.c: add #include <stdlib.h> for free(). Fix PR build/13372.
+
2011-02-14 Mike Frysinger <vapier@gentoo.org>
* cap.c (cap_remove): Change zfree to free.
next prev parent reply other threads:[~2011-11-03 15:01 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-02 17:15 Ben Golding
2011-11-02 18:40 ` Tom Tromey
2011-11-03 15:01 ` Ben Golding [this message]
2011-11-03 15:48 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1320332452.80694.YahooMailNeo@web27507.mail.ukl.yahoo.com \
--to=ben_golding@yahoo.co.uk \
--cc=gdb-patches@sourceware.org \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox