From: Tom Tromey <tromey@redhat.com>
To: Ben Golding <ben_golding@yahoo.co.uk>
Cc: "gdb-patches\@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: [patch] Fix PR build/13372
Date: Wed, 02 Nov 2011 18:40:00 -0000 [thread overview]
Message-ID: <m3y5vywepv.fsf@fleche.redhat.com> (raw)
In-Reply-To: <1320254117.65220.YahooMailNeo@web27507.mail.ukl.yahoo.com> (Ben Golding's message of "Wed, 2 Nov 2011 17:15:17 +0000 (GMT)")
>>>>> "Ben" == Ben Golding <ben_golding@yahoo.co.uk> writes:
Ben> (Apologies I'm not familiar with the usual process for submitting
Ben> patches...)
No problem.
It is missing a ChangeLog entry. Could you write one? They are
described in the GNU coding standards and there are also many examples
in the tree.
Ben> Patch generated with diff -cp:
Patch looks reasonable to me.
Tom
next prev parent reply other threads:[~2011-11-02 18:40 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-02 17:15 Ben Golding
2011-11-02 18:40 ` Tom Tromey [this message]
2011-11-03 15:01 ` Ben Golding
2011-11-03 15:48 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3y5vywepv.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=ben_golding@yahoo.co.uk \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox