From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18005 invoked by alias); 2 Nov 2011 18:40:20 -0000 Received: (qmail 17995 invoked by uid 22791); 2 Nov 2011 18:40:19 -0000 X-SWARE-Spam-Status: No, hits=-7.5 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 02 Nov 2011 18:40:03 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id pA2IdwjF001290 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Wed, 2 Nov 2011 14:40:03 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id pA2IdwLN014934; Wed, 2 Nov 2011 14:39:58 -0400 Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id pA2Idu9i030466; Wed, 2 Nov 2011 14:39:57 -0400 From: Tom Tromey To: Ben Golding Cc: "gdb-patches\@sourceware.org" Subject: Re: [patch] Fix PR build/13372 References: <1320254117.65220.YahooMailNeo@web27507.mail.ukl.yahoo.com> Date: Wed, 02 Nov 2011 18:40:00 -0000 In-Reply-To: <1320254117.65220.YahooMailNeo@web27507.mail.ukl.yahoo.com> (Ben Golding's message of "Wed, 2 Nov 2011 17:15:17 +0000 (GMT)") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.90 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-11/txt/msg00048.txt.bz2 >>>>> "Ben" == Ben Golding writes: Ben> (Apologies I'm not familiar with the usual process for submitting Ben> patches...) No problem. It is missing a ChangeLog entry. Could you write one? They are described in the GNU coding standards and there are also many examples in the tree. Ben> Patch generated with diff -cp: Patch looks reasonable to me. Tom