Re: [PATCH 1/4] 'catch syscall' feature -- Architecture-independent part

["Sérgio Durigan Júnior" <sergiodj@linux.vnet.ibm.com>]

Hi Joel,

On Mon, 2008-10-06 at 13:21 -0400, Joel Brobecker wrote:
>   2. I think it should be possible to split the fork/vfork ops
>      out into a separate file.  But the fork/vfork bp_ops use
>      some static routines from breakpoint.c, and I don't necessarily
>      want these routines to be exported.  One solution would be to
>      include a .c file from inside breakpoint.c.  Not sure that
>      this is very elegant either.  For now, I elected to stay focused
>      on the conversion.  Just some thoughts maybe for later.

IMHO this is not an elegant choice, though I don't have any better
solution in mind now :-(

> OK to commit? I think on principle Daniel agreed, but the devil is
> often in the details...

So, Daniel already reviewed your patch :-). As my rework on catch
syscall heavily depends on your patch, I'm waiting until it gets pushed
upstream so that I can start to modify things here.

Thank you,

-- 
Sérgio Durigan Júnior
Linux on Power Toolchain - Software Engineer
Linux Technology Center - LTC
IBM Brazil