[RFA] Delete breakpoint.c local variables

[RFA] Delete breakpoint.c local variables

[Phil Muldoon]

While stepping through breakpoint.c longjmp breakpoint code, I noticed 
some small trivial unused local variables. Patch to fix.

2008-07-30  Phil Muldoon  <pmuldoon@redhat.com>

    * breakpoint.c (create_longjmp_breakpoint): Remove unused struct
    breakpoint.
    (set_longjmp_breakpoint): Likewise.


Index: gdb/breakpoint.c
===================================================================
RCS file: /cvs/src/src/gdb/breakpoint.c,v
retrieving revision 1.338
diff -u -r1.338 breakpoint.c
--- gdb/breakpoint.c    28 Jul 2008 17:53:52 -0000    1.338
+++ gdb/breakpoint.c    30 Jul 2008 16:56:07 -0000
@@ -4466,7 +4466,6 @@
 static void
 create_longjmp_breakpoint (char *func_name)
 {
-  struct breakpoint *b;
   struct minimal_symbol *m;
 
   if ((m = lookup_minimal_symbol_text (func_name, NULL)) == NULL)
@@ -4482,8 +4481,6 @@
 void
 set_longjmp_breakpoint (void)
 {
-  struct breakpoint *b;
-
   if (gdbarch_get_longjmp_target_p (current_gdbarch))
     {
       create_longjmp_breakpoint ("longjmp");

Re: [RFA] Delete breakpoint.c local variables

[Michael Snyder]

On Wed, 2008-07-30 at 18:03 +0100, Phil Muldoon wrote:
> While stepping through breakpoint.c longjmp breakpoint code, I noticed 
> some small trivial unused local variables. Patch to fix.
> 
> 2008-07-30  Phil Muldoon  <pmuldoon@redhat.com>
> 
>     * breakpoint.c (create_longjmp_breakpoint): Remove unused struct
>     breakpoint.
>     (set_longjmp_breakpoint): Likewise.

OK, thanks.  Please commit.

Re: [RFA] Delete breakpoint.c local variables

[Phil Muldoon]

Michael Snyder wrote:
> On Wed, 2008-07-30 at 18:03 +0100, Phil Muldoon wrote:
>   
>> While stepping through breakpoint.c longjmp breakpoint code, I noticed 
>> some small trivial unused local variables. Patch to fix.
>>
>> 2008-07-30  Phil Muldoon  <pmuldoon@redhat.com>
>>
>>     * breakpoint.c (create_longjmp_breakpoint): Remove unused struct
>>     breakpoint.
>>     (set_longjmp_breakpoint): Likewise.
>>     
>
> OK, thanks.  Please commit

Michael,

Hi and thanks for the review. I am in fact a complete newbie to GDB 
development, and do not have commit after approval authorization. So 
could you, or someone else please commit the patch and ChangeLog?

Thanks!

Phil Muldoon

Re: [RFA] Delete breakpoint.c local variables

[Michael Snyder]

On Mon, 2008-08-04 at 16:44 +0100, Phil Muldoon wrote:
> Michael Snyder wrote:
> > On Wed, 2008-07-30 at 18:03 +0100, Phil Muldoon wrote:
> >   
> >> While stepping through breakpoint.c longjmp breakpoint code, I noticed 
> >> some small trivial unused local variables. Patch to fix.
> >>
> >> 2008-07-30  Phil Muldoon  <pmuldoon@redhat.com>
> >>
> >>     * breakpoint.c (create_longjmp_breakpoint): Remove unused struct
> >>     breakpoint.
> >>     (set_longjmp_breakpoint): Likewise.
> >>     
> >
> > OK, thanks.  Please commit
> 
> Michael,
> 
> Hi and thanks for the review. I am in fact a complete newbie to GDB 
> development, and do not have commit after approval authorization. So 
> could you, or someone else please commit the patch and ChangeLog?

OK, it's done.

How odd, I thought I had seen your name in a changelog before.

You do have an account on the sourceware machine, you know...
Or is that for a different project?

Re: [RFA] Delete breakpoint.c local variables

[Phil Muldoon]

Michael Snyder wrote:
> On Mon, 2008-08-04 at 16:44 +0100, Phil Muldoon wrote:
>   
>> Michael Snyder wrote:
>>     
>>> On Wed, 2008-07-30 at 18:03 +0100, Phil Muldoon wrote:
>>>   
>>>       
>>>> While stepping through breakpoint.c longjmp breakpoint code, I noticed 
>>>> some small trivial unused local variables. Patch to fix.
>>>>
>>>> 2008-07-30  Phil Muldoon  <pmuldoon@redhat.com>
>>>>
>>>>     * breakpoint.c (create_longjmp_breakpoint): Remove unused struct
>>>>     breakpoint.
>>>>     (set_longjmp_breakpoint): Likewise.
>>>>     
>>>>         
>>> OK, thanks.  Please commit
>>>       
>> Michael,
>>
>> Hi and thanks for the review. I am in fact a complete newbie to GDB 
>> development, and do not have commit after approval authorization. So 
>> could you, or someone else please commit the patch and ChangeLog?
>>     
>
> OK, it's done.
>
> How odd, I thought I had seen your name in a changelog before.
>
> You do have an account on the sourceware machine, you know...
> Or is that for a different project?
>   

Yep that was for Frysk. But thanks for committing this. Just so happens 
that everything was straightened out for me to do commit after approval 
last night. So hopefully this is the first - and last time - you will 
have to do the actual commit on my behalf after approval ;)

Regards

Phil

Re: [RFA] Delete breakpoint.c local variables

[Daniel Jacobowitz]

On Wed, Aug 06, 2008 at 09:20:41AM +0100, Phil Muldoon wrote:
> Yep that was for Frysk. But thanks for committing this. Just so happens  
> that everything was straightened out for me to do commit after approval  
> last night. So hopefully this is the first - and last time - you will  
> have to do the actual commit on my behalf after approval ;)

In that case, please add yourself to the write-after-approval section
of gdb/MAINTAINERS.

-- 
Daniel Jacobowitz
CodeSourcery