From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 2228 invoked by alias); 6 Aug 2008 04:31:29 -0000 Received: (qmail 2218 invoked by uid 22791); 6 Aug 2008 04:31:28 -0000 X-Spam-Check-By: sourceware.org Received: from bluesmobile.specifix.com (HELO bluesmobile.specifix.com) (216.129.118.140) by sourceware.org (qpsmtpd/0.31) with ESMTP; Wed, 06 Aug 2008 04:27:01 +0000 Received: from [127.0.0.1] (bluesmobile.specifix.com [216.129.118.140]) by bluesmobile.specifix.com (Postfix) with ESMTP id 000C33B940; Tue, 5 Aug 2008 21:26:59 -0700 (PDT) Subject: Re: [RFA] Delete breakpoint.c local variables From: Michael Snyder To: Phil Muldoon Cc: gdb-patches@sourceware.org In-Reply-To: <489723F8.4030109@redhat.com> References: <48909EDB.3050001@redhat.com> <1217721030.3549.641.camel@localhost.localdomain> <489723F8.4030109@redhat.com> Content-Type: text/plain Date: Wed, 06 Aug 2008 04:31:00 -0000 Message-Id: <1217996819.3549.658.camel@localhost.localdomain> Mime-Version: 1.0 X-Mailer: Evolution 2.10.3 (2.10.3-7.fc7) Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-08/txt/msg00098.txt.bz2 On Mon, 2008-08-04 at 16:44 +0100, Phil Muldoon wrote: > Michael Snyder wrote: > > On Wed, 2008-07-30 at 18:03 +0100, Phil Muldoon wrote: > > > >> While stepping through breakpoint.c longjmp breakpoint code, I noticed > >> some small trivial unused local variables. Patch to fix. > >> > >> 2008-07-30 Phil Muldoon > >> > >> * breakpoint.c (create_longjmp_breakpoint): Remove unused struct > >> breakpoint. > >> (set_longjmp_breakpoint): Likewise. > >> > > > > OK, thanks. Please commit > > Michael, > > Hi and thanks for the review. I am in fact a complete newbie to GDB > development, and do not have commit after approval authorization. So > could you, or someone else please commit the patch and ChangeLog? OK, it's done. How odd, I thought I had seen your name in a changelog before. You do have an account on the sourceware machine, you know... Or is that for a different project?