From: Phil Muldoon <pmuldoon@redhat.com>
To: Michael Snyder <msnyder@specifix.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [RFA] Delete breakpoint.c local variables
Date: Wed, 06 Aug 2008 08:21:00 -0000 [thread overview]
Message-ID: <48995ED9.8060400@redhat.com> (raw)
In-Reply-To: <1217996819.3549.658.camel@localhost.localdomain>
Michael Snyder wrote:
> On Mon, 2008-08-04 at 16:44 +0100, Phil Muldoon wrote:
>
>> Michael Snyder wrote:
>>
>>> On Wed, 2008-07-30 at 18:03 +0100, Phil Muldoon wrote:
>>>
>>>
>>>> While stepping through breakpoint.c longjmp breakpoint code, I noticed
>>>> some small trivial unused local variables. Patch to fix.
>>>>
>>>> 2008-07-30 Phil Muldoon <pmuldoon@redhat.com>
>>>>
>>>> * breakpoint.c (create_longjmp_breakpoint): Remove unused struct
>>>> breakpoint.
>>>> (set_longjmp_breakpoint): Likewise.
>>>>
>>>>
>>> OK, thanks. Please commit
>>>
>> Michael,
>>
>> Hi and thanks for the review. I am in fact a complete newbie to GDB
>> development, and do not have commit after approval authorization. So
>> could you, or someone else please commit the patch and ChangeLog?
>>
>
> OK, it's done.
>
> How odd, I thought I had seen your name in a changelog before.
>
> You do have an account on the sourceware machine, you know...
> Or is that for a different project?
>
Yep that was for Frysk. But thanks for committing this. Just so happens
that everything was straightened out for me to do commit after approval
last night. So hopefully this is the first - and last time - you will
have to do the actual commit on my behalf after approval ;)
Regards
Phil
next prev parent reply other threads:[~2008-08-06 8:21 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-30 17:03 Phil Muldoon
2008-08-02 23:51 ` Michael Snyder
2008-08-04 15:46 ` Phil Muldoon
2008-08-06 4:31 ` Michael Snyder
2008-08-06 8:21 ` Phil Muldoon [this message]
2008-08-06 11:28 ` Daniel Jacobowitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48995ED9.8060400@redhat.com \
--to=pmuldoon@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=msnyder@specifix.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox