From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22047 invoked by alias); 6 Aug 2008 08:21:19 -0000 Received: (qmail 22038 invoked by uid 22791); 6 Aug 2008 08:21:19 -0000 X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (66.187.233.31) by sourceware.org (qpsmtpd/0.31) with ESMTP; Wed, 06 Aug 2008 08:20:44 +0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id m768Kgos032342; Wed, 6 Aug 2008 04:20:42 -0400 Received: from file.rdu.redhat.com (file.rdu.redhat.com [10.11.255.147]) by int-mx1.corp.redhat.com (8.13.1/8.13.1) with ESMTP id m768KgFa028969; Wed, 6 Aug 2008 04:20:42 -0400 Received: from localhost.localdomain (vpn-4-130.str.redhat.com [10.32.4.130]) by file.rdu.redhat.com (8.13.1/8.13.1) with ESMTP id m768Ke6K015342; Wed, 6 Aug 2008 04:20:41 -0400 Message-ID: <48995ED9.8060400@redhat.com> Date: Wed, 06 Aug 2008 08:21:00 -0000 From: Phil Muldoon User-Agent: Thunderbird 2.0.0.14 (X11/20080501) MIME-Version: 1.0 To: Michael Snyder CC: gdb-patches@sourceware.org Subject: Re: [RFA] Delete breakpoint.c local variables References: <48909EDB.3050001@redhat.com> <1217721030.3549.641.camel@localhost.localdomain> <489723F8.4030109@redhat.com> <1217996819.3549.658.camel@localhost.localdomain> In-Reply-To: <1217996819.3549.658.camel@localhost.localdomain> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-08/txt/msg00104.txt.bz2 Michael Snyder wrote: > On Mon, 2008-08-04 at 16:44 +0100, Phil Muldoon wrote: > >> Michael Snyder wrote: >> >>> On Wed, 2008-07-30 at 18:03 +0100, Phil Muldoon wrote: >>> >>> >>>> While stepping through breakpoint.c longjmp breakpoint code, I noticed >>>> some small trivial unused local variables. Patch to fix. >>>> >>>> 2008-07-30 Phil Muldoon >>>> >>>> * breakpoint.c (create_longjmp_breakpoint): Remove unused struct >>>> breakpoint. >>>> (set_longjmp_breakpoint): Likewise. >>>> >>>> >>> OK, thanks. Please commit >>> >> Michael, >> >> Hi and thanks for the review. I am in fact a complete newbie to GDB >> development, and do not have commit after approval authorization. So >> could you, or someone else please commit the patch and ChangeLog? >> > > OK, it's done. > > How odd, I thought I had seen your name in a changelog before. > > You do have an account on the sourceware machine, you know... > Or is that for a different project? > Yep that was for Frysk. But thanks for committing this. Just so happens that everything was straightened out for me to do commit after approval last night. So hopefully this is the first - and last time - you will have to do the actual commit on my behalf after approval ;) Regards Phil