From: Luis Machado <luisgpm@linux.vnet.ibm.com>
To: Pierre Muller <muller@ics.u-strasbg.fr>
Cc: "'Daniel Jacobowitz'" <drow@false.org>, gdb-patches@sourceware.org
Subject: Re: [RFC/RFA] testsuite/gdb.base/watch_thread_num.exp: Fix test for systems having hidden threads
Date: Wed, 19 Dec 2007 13:56:00 -0000 [thread overview]
Message-ID: <1198072304.1209.21.camel@gargoyle> (raw)
In-Reply-To: <000601c8423e$f49ca010$ddd5e030$@u-strasbg.fr>
Hi Pierre,
On Wed, 2007-12-19 at 13:59 +0100, Pierre Muller wrote:
> This test currently fails on cygwin target
> and it does by timeout's which means that it takes a lot of time...
> The reason of the failure is that
> thread #2 is a thread created internally by cygwin,
> for posix emulation, and thus never
> changes the value of the variable shared_var.
Thanks for pointing this out. I wasn't aware of that fact.
> * (gdb.base/watch_thread_num.exp): Add breakpoint at
> thread_function and record first explicitly generated
> thread number.
> Use that thread number for thread specific watchpoint test.
> Add iteration number to repetitive tests.
Looks OK. Maybe just "Use thread number for testing" and "Add iteration
number" will do on those two phrases.
> +gdb_test "disable 2" "" "Disable breakpoint 2"
Maybe a comment on why this is being explicitly disabled because of
Cygwin?
The other portions of the patch look OK to me.
The patch has 29 passes on PPC as well.
Regards,
--
Luis Machado
Software Engineer
IBM Linux Technology Center
next prev parent reply other threads:[~2007-12-19 13:52 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-16 21:03 [patch] Watchpoints: support for thread <thread_num> parameters Luis Machado
2007-08-17 10:24 ` Eli Zaretskii
2007-08-17 15:47 ` Luis Machado
2007-08-17 18:41 ` Eli Zaretskii
2007-08-17 18:50 ` Daniel Jacobowitz
2007-08-20 14:28 ` Luis Machado
2007-08-20 14:21 ` Daniel Jacobowitz
2007-08-20 15:23 ` Luis Machado
2007-08-20 15:29 ` Daniel Jacobowitz
2007-08-23 21:08 ` Joel Brobecker
2007-08-23 21:15 ` Luis Machado
2007-10-11 19:40 ` Daniel Jacobowitz
2007-10-11 20:33 ` Luis Machado
2007-11-13 14:50 ` Luis Machado
2007-11-13 15:38 ` Andreas Schwab
2007-11-13 22:30 ` Eli Zaretskii
2007-11-14 12:20 ` Luis Machado
2007-11-30 16:10 ` Luis Machado
2007-12-16 21:50 ` Daniel Jacobowitz
2007-12-17 13:29 ` Luis Machado
2007-12-19 13:05 ` [RFC/RFA] testsuite/gdb.base/watch_thread_num.exp: Fix test for systems having hidden threads Pierre Muller
2007-12-19 13:56 ` Luis Machado [this message]
2007-12-19 14:04 ` Pierre Muller
2007-12-19 14:05 ` 'Daniel Jacobowitz'
2007-12-19 14:55 ` Pierre Muller
2007-12-19 15:04 ` 'Daniel Jacobowitz'
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1198072304.1209.21.camel@gargoyle \
--to=luisgpm@linux.vnet.ibm.com \
--cc=drow@false.org \
--cc=gdb-patches@sourceware.org \
--cc=muller@ics.u-strasbg.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox