From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19289 invoked by alias); 19 Dec 2007 13:52:05 -0000 Received: (qmail 19278 invoked by uid 22791); 19 Dec 2007 13:52:05 -0000 X-Spam-Check-By: sourceware.org Received: from igw2.br.ibm.com (HELO igw2.br.ibm.com) (32.104.18.25) by sourceware.org (qpsmtpd/0.31) with ESMTP; Wed, 19 Dec 2007 13:51:52 +0000 Received: from mailhub1.br.ibm.com (mailhub1 [9.18.232.109]) by igw2.br.ibm.com (Postfix) with ESMTP id 38C1D17F5EF for ; Wed, 19 Dec 2007 11:47:01 -0200 (BRDT) Received: from d24av02.br.ibm.com (d24av02.br.ibm.com [9.18.232.47]) by mailhub1.br.ibm.com (8.13.8/8.13.8/NCO v8.7) with ESMTP id lBJDpo2v4096128 for ; Wed, 19 Dec 2007 11:51:50 -0200 Received: from d24av02.br.ibm.com (loopback [127.0.0.1]) by d24av02.br.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id lBJDplTc031840 for ; Wed, 19 Dec 2007 11:51:49 -0200 Received: from [9.18.238.20] ([9.18.238.20]) by d24av02.br.ibm.com (8.12.11.20060308/8.12.11) with ESMTP id lBJDpjjo031819 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Wed, 19 Dec 2007 11:51:45 -0200 Subject: Re: [RFC/RFA] testsuite/gdb.base/watch_thread_num.exp: Fix test for systems having hidden threads From: Luis Machado Reply-To: luisgpm@linux.vnet.ibm.com To: Pierre Muller Cc: "'Daniel Jacobowitz'" , gdb-patches@sourceware.org In-Reply-To: <000601c8423e$f49ca010$ddd5e030$@u-strasbg.fr> References: <1187298178.5853.11.camel@localhost> <1187365616.4520.14.camel@localhost> <20071011193558.GE30810@caradoc.them.org> <1192134591.18528.1.camel@localhost> <1194961811.4820.3.camel@localhost> <1195042801.4908.2.camel@localhost> <20071216214836.GE2618@caradoc.them.org> <1197894945.24027.8.camel@gargoyle> <000601c8423e$f49ca010$ddd5e030$@u-strasbg.fr> Content-Type: text/plain Date: Wed, 19 Dec 2007 13:56:00 -0000 Message-Id: <1198072304.1209.21.camel@gargoyle> Mime-Version: 1.0 X-Mailer: Evolution 2.12.1 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-12/txt/msg00302.txt.bz2 Hi Pierre, On Wed, 2007-12-19 at 13:59 +0100, Pierre Muller wrote: > This test currently fails on cygwin target > and it does by timeout's which means that it takes a lot of time... > The reason of the failure is that > thread #2 is a thread created internally by cygwin, > for posix emulation, and thus never > changes the value of the variable shared_var. Thanks for pointing this out. I wasn't aware of that fact. > * (gdb.base/watch_thread_num.exp): Add breakpoint at > thread_function and record first explicitly generated > thread number. > Use that thread number for thread specific watchpoint test. > Add iteration number to repetitive tests. Looks OK. Maybe just "Use thread number for testing" and "Add iteration number" will do on those two phrases. > +gdb_test "disable 2" "" "Disable breakpoint 2" Maybe a comment on why this is being explicitly disabled because of Cygwin? The other portions of the patch look OK to me. The patch has 29 passes on PPC as well. Regards, -- Luis Machado Software Engineer IBM Linux Technology Center