[patch] realloc bug in add_symbol_file_command

[patch] realloc bug in add_symbol_file_command

[Jean-Marc Saffroy]

Hello,

In gdb 6.5 I had systematic crashes with add-symbol-file: my kernel 
modules have many sections... :) The patch below lets me load many modules 
now.


Cheers,

-- 
saffroy@gmail.com

Index: gdb-6.5/gdb/symfile.c
===================================================================
--- gdb-6.5.orig/gdb/symfile.c	2006-10-06 15:56:41.000000000 +0200
+++ gdb-6.5/gdb/symfile.c	2006-10-06 15:57:52.000000000 +0200
@@ -1852,7 +1852,7 @@
                 to load the program. */
  	    sect_opts[section_index].name = ".text";
  	    sect_opts[section_index].value = arg;
-	    if (++section_index > num_sect_opts)
+	    if (++section_index == num_sect_opts)
  	      {
  		num_sect_opts *= 2;
  		sect_opts = ((struct sect_opt *)
@@ -1888,7 +1888,7 @@
  		    {
  		      sect_opts[section_index].value = arg;
  		      expecting_sec_addr = 0;
-		      if (++section_index > num_sect_opts)
+		      if (++section_index == num_sect_opts)
  			{
  			  num_sect_opts *= 2;
  			  sect_opts = ((struct sect_opt *)

Re: [patch] realloc bug in add_symbol_file_command

[Michael Snyder]

On Fri, 2006-10-06 at 16:16 +0200, Jean-Marc Saffroy wrote:
> Hello,
> 
> In gdb 6.5 I had systematic crashes with add-symbol-file: my kernel 
> modules have many sections... :) The patch below lets me load many modules 
> now.

Just to be safe, might you want to use >=?

Re: [patch] realloc bug in add_symbol_file_command

[Jean-Marc Saffroy]

On Fri, 6 Oct 2006, Michael Snyder wrote:

> On Fri, 2006-10-06 at 16:16 +0200, Jean-Marc Saffroy wrote:
>> Hello,
>>
>> In gdb 6.5 I had systematic crashes with add-symbol-file: my kernel
>> modules have many sections... :) The patch below lets me load many modules
>> now.
>
> Just to be safe, might you want to use >=?

Do you fear the processor would skip a number when incrementing the 
variable indexing the section array? ;-)

Given the current code, it should not be necessary in any way, but feel 
free to change the patch as you please.


Cheers,

-- 
saffroy@gmail.com

Re: [patch] realloc bug in add_symbol_file_command

[Michael Snyder]

On Fri, 2006-10-06 at 23:57 +0200, Jean-Marc Saffroy wrote:
> On Fri, 6 Oct 2006, Michael Snyder wrote:
> 
> > On Fri, 2006-10-06 at 16:16 +0200, Jean-Marc Saffroy wrote:
> >> Hello,
> >>
> >> In gdb 6.5 I had systematic crashes with add-symbol-file: my kernel
> >> modules have many sections... :) The patch below lets me load many modules
> >> now.
> >
> > Just to be safe, might you want to use >=?
> 
> Do you fear the processor would skip a number when incrementing the 
> variable indexing the section array? ;-)

Yes.  I'm just paranoid that way.   ;-)

> Given the current code, it should not be necessary in any way, but feel 
> free to change the patch as you please.

It was just a suggestion, not a demand.

Anyway, I was going to approve your change, but I see that it's
already in.  Andreas Schwab anticipated you on August 24.   
Great minds think alike.  ;-)